Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript and JavaScript organize imports #45108

Closed
mjbvz opened this issue Mar 6, 2018 · 2 comments · Fixed by #45237
Closed

TypeScript and JavaScript organize imports #45108

mjbvz opened this issue Mar 6, 2018 · 2 comments · Fixed by #45237
Assignees
Labels
feature-request Request for new features or functionality javascript JavaScript support issues on-testplan typescript Typescript support issues
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Mar 6, 2018

Add support for TypeScript organize imports command. This command:

  • Sorts imports
  • Remove unused imports
  • Other?
@mjbvz mjbvz added typescript Typescript support issues javascript JavaScript support issues labels Mar 6, 2018
@mjbvz mjbvz added this to the March 2018 milestone Mar 6, 2018
@mjbvz mjbvz self-assigned this Mar 6, 2018
@mjbvz mjbvz added the feature-request Request for new features or functionality label Mar 7, 2018
@mjbvz mjbvz mentioned this issue Mar 16, 2018
@yuval-gilboa
Copy link

We're currently using tslint (in particular the "ordered-imports" rule) to group and sort imports. Will this new feature conflict with that? Will you provide similar capabilities for controlling the sorting and grouping order?

@yuval-gilboa
Copy link

Also look into the typescript sort imports extension (https://marketplace.visualstudio.com/items?itemName=miclo.sort-typescript-imports) which gives great deal of control over sorting and grouping order.

mjbvz added a commit to mjbvz/vscode that referenced this issue Mar 20, 2018
Adds a new 'Organize Imports' command for js and ts. This command is only availible on TS 2.8+. We'll hold off on merging this PR until we pick up a TS 2.8 insiders build

Fixes microsoft#45108
mjbvz added a commit that referenced this issue Mar 20, 2018
* Organize imports for js and ts

Adds a new 'Organize Imports' command for js and ts. This command is only availible on TS 2.8+. We'll hold off on merging this PR until we pick up a TS 2.8 insiders build

Fixes #45108

* Add keybinding for organize imports
@vscodebot vscodebot bot locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality javascript JavaScript support issues on-testplan typescript Typescript support issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants