New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify user that a language pack install requires a vscode restart #44501
Comments
@sandy081 since we now ship the LP we should look into this for May. Can you look into the extension viewlet ? |
@dbaeumer Restart on language pack installation message is already implemented in last milestone. Let me know if you are looking for more? |
@dbaeumer Do you want to show the prompt when the user changes the locale in |
I tweak the content of the file to make it more obvious that a restart is required. I would right now not spend to much time on it since it is a very rare user action. |
Let me know what you think. |
Makes sense to me |
Closing then. @isidorn please speak up if you feel strongly about it. The locale.json will look like this: {
"locale": "de" // Changes will not take effect until VS Code has been restarted.
} |
One additional things to mention. When VS Code prompts to install a language pack and you do it automatically restarts. So that case is covered. |
Refs: #44426
If a user installs a language pack, he is required to restart vscode in order for this langugae pack to take effect.
I notice that in locale.json we have a message that a restart is required, however a user can easily miss that.
I would expect that:
The text was updated successfully, but these errors were encountered: