Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user that a language pack install requires a vscode restart #44501

Closed
isidorn opened this issue Feb 27, 2018 · 8 comments
Closed

Notify user that a language pack install requires a vscode restart #44501

isidorn opened this issue Feb 27, 2018 · 8 comments
Assignees
Labels
feature-request Request for new features or functionality l10n-platform Localization platform issues (not wrong translations) verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Feb 27, 2018

Refs: #44426

If a user installs a language pack, he is required to restart vscode in order for this langugae pack to take effect.
I notice that in locale.json we have a message that a restart is required, however a user can easily miss that.

I would expect that:

  • Every time a locale.json value changes there is a notication with an action to restart vscode
  • Every time a language pack is installed the same notificaiton shows up
@isidorn isidorn added feature-request Request for new features or functionality l10n-platform Localization platform issues (not wrong translations) labels Feb 27, 2018
@dbaeumer dbaeumer added this to the Backlog milestone Feb 27, 2018
@dbaeumer dbaeumer modified the milestones: Backlog, May 2018 May 7, 2018
@dbaeumer
Copy link
Member

dbaeumer commented May 7, 2018

@sandy081 since we now ship the LP we should look into this for May. Can you look into the extension viewlet ?

@sandy081
Copy link
Member

sandy081 commented May 7, 2018

@dbaeumer Restart on language pack installation message is already implemented in last milestone.

Let me know if you are looking for more?

@sandy081 sandy081 modified the milestones: May 2018, June 2018 May 28, 2018
@sandy081
Copy link
Member

@dbaeumer Do you want to show the prompt when the user changes the locale in locale.json also?

@sandy081 sandy081 removed this from the June 2018 milestone Jun 25, 2018
@dbaeumer
Copy link
Member

I tweak the content of the file to make it more obvious that a restart is required. I would right now not spend to much time on it since it is a very rare user action.

@dbaeumer
Copy link
Member

Let me know what you think.

@sandy081
Copy link
Member

Makes sense to me

@dbaeumer
Copy link
Member

Closing then. @isidorn please speak up if you feel strongly about it. The locale.json will look like this:

{
   "locale": "de" // Changes will not take effect until VS Code has been restarted. 
}

@dbaeumer
Copy link
Member

One additional things to mention. When VS Code prompts to install a language pack and you do it automatically restarts. So that case is covered.

@isidorn isidorn added this to the June 2018 milestone Jun 27, 2018
@isidorn isidorn added verification-needed Verification of issue is requested verified Verification succeeded labels Jun 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality l10n-platform Localization platform issues (not wrong translations) verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants