Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare Selected should not be in the context menu when one of the selected item is a folder #42575

Closed
ramya-rao-a opened this issue Jan 30, 2018 · 2 comments
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

Testing #41473

Compare Selected should not be in the context menu when one of the selected item is a folder

@isidorn
Copy link
Contributor

isidorn commented Jan 31, 2018

This is a fair feature request.
However due to the limitation of context keys and how we structured them I will not implement this. Also do not see the big downside of showing this.

Code pointers
https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/files/electron-browser/fileActions.contribution.ts#L276

Basically instead of WorkbenchListDoubleSelection and focus is on file the context should Double file selected.

@isidorn isidorn added this to the Backlog milestone Jan 31, 2018
@isidorn isidorn added feature-request Request for new features or functionality file-explorer Explorer widget issues labels Jan 31, 2018
@isidorn isidorn removed their assignment Jan 31, 2018
@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Sep 21, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 21, 2018

This iteration we focus on issue grooming. This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

2 participants