Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode does not handle Nested Merge Conflicts #37845

Closed
Alexhuszagh opened this issue Nov 8, 2017 · 4 comments
Closed

VSCode does not handle Nested Merge Conflicts #37845

Alexhuszagh opened this issue Nov 8, 2017 · 4 comments
Assignees
Labels
info-needed Issue requires more information from poster merge-conflict Merge conflict decorations and actions

Comments

@Alexhuszagh
Copy link

  • VSCode Version: 1.17.2, 1.17.2
  • OS Version: Ubuntu 17.04

Steps to Reproduce:

  1. Open text file with any encoding.
  2. Paste the following into the file.
If you have questions, please
<<<<<<< HEAD
<<<<<<< HEAD
=======
>>>>>>> branch-a
=======
>>>>>>> branch-a

If you paste just the inner merge conflict, VSCode properly identifies a merge conflict and provides the UI to resolve the conflict. However, for nested merge conflicts, it does not identify the merge conflicts, or does not provide a UI to resolve them.

Reproduces without extensions: Yes

@vscodebot vscodebot bot added the merge-conflict Merge conflict decorations and actions label Nov 8, 2017
@chrmarti
Copy link
Contributor

chrmarti commented Dec 1, 2017

How do you get nested merge conflicts through a tool, not manually?

@chrmarti chrmarti added the info-needed Issue requires more information from poster label Dec 1, 2017
@Alexhuszagh
Copy link
Author

@chrmarti You can get them (albeit rarely) using the standard git tool with rebases. If you are rebasing on a branch that has restructured a large section of code, and you have made small changes to that section, you can have an outer conflict with an inner conflict. I'll try to get a working example, I had one for a FOSS project I was making a PR for, but I should be able to create a minimal, verifiable, complete example.

@chrmarti
Copy link
Contributor

@Alexhuszagh Did you find a reproducible case?

@vscodebot vscodebot bot closed this as completed Mar 6, 2018
@vscodebot
Copy link

vscodebot bot commented Mar 6, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster merge-conflict Merge conflict decorations and actions
Projects
None yet
Development

No branches or pull requests

2 participants