Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed theme only available in one window #35585

Closed
kieferrm opened this issue Oct 4, 2017 · 2 comments
Closed

Installed theme only available in one window #35585

kieferrm opened this issue Oct 4, 2017 · 2 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) extension-host Extension host issues

Comments

@kieferrm
Copy link
Member

kieferrm commented Oct 4, 2017

  • VSCode Version: Code - Insiders 1.17.0-insider (81fc22e, 2017-10-03T23:17:52.245Z)
  • OS Version: Windows_NT x64 10.0.16362
  • Extensions:
Extension Author (truncated) Version
vsc-material-theme Equ 1.0.4

(1 theme extensions excluded)


Steps to Reproduce:

  1. Open two workspaces
  2. In one of the windows install a new theme
  3. Reload Window
  4. Change theme to newly installed theme
    -> the other window still has the old theme, when you want to change to the new theme explicitly, it's not in the list of available themes

This behavior is different from when I re-launch VS Code with the theme already installed. All theme changes are taking affect across all windows.

Reproduces without extensions: Yes/No

@sandy081
Copy link
Member

sandy081 commented Oct 5, 2017

This is because, every window has its own extension host. We need to reload the window when a new extension is installed and for the extension to take effect.

@sandy081 sandy081 removed their assignment Oct 5, 2017
@sandy081 sandy081 added extension-host Extension host issues and removed workbench labels Oct 5, 2017
@sandy081
Copy link
Member

sandy081 commented Oct 5, 2017

Duplicate of #5675

@sandy081 sandy081 marked this as a duplicate of #5675 Oct 5, 2017
@sandy081 sandy081 closed this as completed Oct 5, 2017
@sandy081 sandy081 added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 5, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) extension-host Extension host issues
Projects
None yet
Development

No branches or pull requests

2 participants