Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab Drag and Drop between editors is CPU intensive #28441

Closed
youurayy opened this issue Jun 11, 2017 · 5 comments
Closed

Tab Drag and Drop between editors is CPU intensive #28441

youurayy opened this issue Jun 11, 2017 · 5 comments
Assignees
Labels
perf upstream Issue identified as 'upstream' component related (exists outside of VS Code) workbench-dnd Drag-and-drop issues workbench-tabs VS Code editor tab issues

Comments

@youurayy
Copy link

  • VSCode Version: 1.13.0
  • OS Version: Windows 10

Steps to Reproduce:

  1. open all 3 editor panes each with multiple files
  2. drag tabs between these (the increased CPU usage happens after the drop)
  3. observe CPU usage

This used to be fast (instant) in previous versions. Now it gives the feel of a heavy UI.

My custom settings:

{
    "window.zoomLevel": 0,
    "workbench.statusBar.visible": true,
    "editor.renderWhitespace": "all",
    "editor.wordWrap": "bounded",
    "editor.tabSize": 2,
    "editor.cursorBlinking": "solid",
    "git.confirmSync": false,
    "window.reopenFolders": "all",
    "window.restoreFullscreen": true,
    "workbench.editor.enablePreview": false,
    "workbench.editor.enablePreviewFromQuickOpen": false,
    "editor.lineNumbers": "off",
    "editor.detectIndentation": false,
    "editor.autoClosingBrackets": false,
    "editor.mouseWheelZoom": false,
    "editor.folding": false,
    "editor.rulers": [],
    "editor.glyphMargin": false,
    "editor.codeLens": false,
    "explorer.openEditors.visible": 999,
    "editor.fontSize": 14,
    "editor.scrollBeyondLastLine": false,
    "editor.quickSuggestions": false,
    "files.trimTrailingWhitespace": true,
    "terminal.integrated.shell.windows": "C:\\cygwin64\\bin\\bash.exe",
    "terminal.integrated.shellArgs.windows": ["/bin/xhere", "/bin/bash"],
    "window.newWindowDimensions": "maximized",
    "files.eol": "\n",
    "workbench.editor.revealIfOpen": false,
    "zenMode.hideTabs": false,
    "zenMode.restore": true,
    "git.enabled": false,
    "git.autorefresh": false,
    "git.autofetch": false,
    "git.countBadge": "tracked",
    "editor.formatOnType": false,
    "workbench.iconTheme": null,
    "editor.renderControlCharacters": true,
    "editor.renderLineHighlight": "all",
    "editor.minimap.enabled": false
}
@bpasero
Copy link
Member

bpasero commented Jun 13, 2017

@youurayy can you record a screencast how you are doing that?

@bpasero bpasero added freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues info-needed Issue requires more information from poster labels Jun 13, 2017
@bpasero bpasero added this to the Backlog milestone Jun 13, 2017
@youurayy
Copy link
Author

@bpasero is there a suggested way to record a screencast on Windows 10?

I've tried to disable editor.renderIndentGuides and it feels a bit snappier although the CPU graphs don't support that. I'll see if I can come back with more info.

@bpasero
Copy link
Member

bpasero commented Jun 13, 2017

@youurayy are you on a 4k monitor maybe?

@youurayy
Copy link
Author

@bpasero yes!

@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) perf and removed freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues info-needed Issue requires more information from poster perf labels Jun 14, 2017
@bpasero bpasero added perf workbench-tabs VS Code editor tab issues labels Nov 11, 2017
@bpasero bpasero removed this from the Backlog milestone Nov 16, 2017
@bpasero bpasero added the workbench-dnd Drag-and-drop issues label Nov 17, 2017
@bpasero
Copy link
Member

bpasero commented Sep 10, 2018

Closing, no plans currently to work on this near term.

@bpasero bpasero closed this as completed Sep 10, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
perf upstream Issue identified as 'upstream' component related (exists outside of VS Code) workbench-dnd Drag-and-drop issues workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

4 participants