Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git: cannot undo a change in this folder #27901

Closed
bpasero opened this issue Jun 2, 2017 · 4 comments
Closed

Git: cannot undo a change in this folder #27901

bpasero opened this issue Jun 2, 2017 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities scm General SCM compound issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 2, 2017

Steps to Reproduce:

  1. have a folder super cool stuff" ---?!?!() sdäü*
  2. add a file
  3. from git viewlet undo

=> nothing happens

Output:

git clean -f -q -- /Users/bpasero/Development/monaco/super cool stuff" ---?!?!() sdäü*/tsfmt.json
git status -z -u
git symbolic-ref --short HEAD
git rev-parse master
git rev-parse --symbolic-full-name --abbrev-ref master@{u}
git rev-list --left-right master...origin/master
git for-each-ref --format %(refname) %(objectname)
git remote --verbose
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues labels Jun 2, 2017
@joaomoreno joaomoreno added this to the June 2017 milestone Jun 13, 2017
@joaomoreno
Copy link
Member

This reproduces with a folder simply named ?.

@joaomoreno joaomoreno modified the milestones: Backlog, June 2017 Jun 27, 2017
@joaomoreno joaomoreno added good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Jun 27, 2017
@ryan-cd
Copy link

ryan-cd commented Aug 25, 2017

I followed the steps on Windows 10, and could not reproduce the problem. Clicking undo deleted the file out of the ? folder.

@seandgrimes
Copy link

This is weird, it looks like git clean is behaving differently depending on whether a directory with a question mark in the name is committed or not. If it's not committed, then something like git clean -f -q -- /Users/sean/Documents/Projects/testing/?/keepme does absolutely nothing, but as soon as I commit keepme and add a different file, then something like git clean -f -q -- /Users/sean/Documents/Projects/testing/?/keepme2 works.

Starting over, if I create a new test repository and then create a directory named test with a single file in it, git clean works just fine even without the directory being part of the commit history.

@joaomoreno
Copy link
Member

#24434

@joaomoreno joaomoreno added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 23, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities scm General SCM compound issues
Projects
None yet
Development

No branches or pull requests

4 participants