Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer a command to open a tree/list's context menu #20814

Closed
d-akara opened this issue Feb 17, 2017 · 11 comments
Closed

Offer a command to open a tree/list's context menu #20814

d-akara opened this issue Feb 17, 2017 · 11 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality tree-widget Tree widget issues

Comments

@d-akara
Copy link

d-akara commented Feb 17, 2017

The context menu when invoked using a key binding only works in an editor. If something else has focus like the file explorer and you invoke the context menu, you will get the context menu of the editor and not the item in focus for the file explorer.

vscode: 1.9.1
OSX 10.11.6

@bpasero
Copy link
Member

bpasero commented Feb 19, 2017

@dakaraphi what keybinding are you using?

@d-akara
Copy link
Author

d-akara commented Feb 19, 2017

@bpasero ctrl+`

@bpasero
Copy link
Member

bpasero commented Feb 19, 2017

@joaomoreno can you reproduce?

@joaomoreno
Copy link
Member

joaomoreno commented Feb 20, 2017

@dakaraphi Did you configure Ctrl+`` to execute the command editor.action.showContextMenu?

@d-akara
Copy link
Author

d-akara commented Feb 20, 2017

@joaomoreno yes.

@joaomoreno
Copy link
Member

The command is meant for showing the editor's context menu, nothing more. We don't have commands to show the context menu of everything else.

@d-akara
Copy link
Author

d-akara commented Feb 20, 2017

@joaomoreno ok, then can this be a feature request. Other editors offer key bindings for the context menu for the item in focus. The more we can use the keyboard and not touch the mouse, the faster the workflow can be.

@bpasero bpasero changed the title Invoking context menu with key binding opens wrong context in file explorer Offer a command to open a tree/list's context menu Feb 20, 2017
@bpasero bpasero added feature-request Request for new features or functionality workbench labels Feb 20, 2017
@bpasero bpasero removed their assignment Feb 20, 2017
@d-akara
Copy link
Author

d-akara commented Feb 20, 2017

Note, for clarity, ideally there should be only 1 command that operates on context for anywhere. This can be a new command, so existing behavior is preserved; however, it would be cumbersome to have to manage different commands based on the type of panel that is active.

@joaomoreno joaomoreno assigned bpasero and unassigned bpasero Feb 21, 2017
@joaomoreno joaomoreno added this to the Backlog milestone Feb 21, 2017
@bpasero
Copy link
Member

bpasero commented Feb 21, 2017

Yeah, this goes in line with our newly introduced list commands: https://github.com/Microsoft/vscode-docs/blob/vnext/release-notes/v1_10.md#configurable-treelist-keybindings

@bpasero bpasero removed this from the Backlog milestone Feb 21, 2017
@bpasero bpasero added tree-widget Tree widget issues accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues and removed workbench labels Nov 16, 2017
@isidorn
Copy link
Contributor

isidorn commented Jun 18, 2019

I think adding a command that shows a tree context menu makes perfect sense from the accessibility point of view.
Asssigning myself and June.
I plan to put it in the listCommands.ts

@isidorn isidorn self-assigned this Jun 18, 2019
@isidorn isidorn added this to the June 2019 milestone Jun 18, 2019
@isidorn
Copy link
Contributor

isidorn commented Jun 20, 2019

After investigating this actually works already. It is just not changable
Shift + F10
This is our standard keybinding, also in the editor.

Thus closing this as it works.
If you still want this configurable let me know and I can reopen, though it is not an accessibility issue then.

@isidorn isidorn closed this as completed Jun 20, 2019
@isidorn isidorn removed this from the June 2019 milestone Jun 20, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality tree-widget Tree widget issues
Projects
None yet
Development

No branches or pull requests

4 participants