Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double clicking fails to open .txt files #93

Closed
leftler opened this issue Apr 26, 2018 · 9 comments
Closed

Double clicking fails to open .txt files #93

leftler opened this issue Apr 26, 2018 · 9 comments
Assignees
Labels
🪲 bug Issue is not intended behavior
Milestone

Comments

@leftler
Copy link

leftler commented Apr 26, 2018

Storage Explorer Version: 1.0.0
OS Version: Windows
Architecture: ia32
Build Number: 20180415.2
Commit: 5d603052

Steps to Reproduce:

  1. Navigate to a file with the .txt extension
  2. Double click to download.

Expected Experience:
The file is downloaded to the temp folder and is opened with my default viewer for .txt files (Notepad++)

Actual Experience:
I get the following message in my Activities log

Failed to open 'INT-LabResultsApi/2018/04/06/15/afb338852ec7227ac269b1f8211ef69976b7dd324bb39cca9bae976603ac7f6c_applicationLog.txt': unknown

Clicking Details provides only the following in the text box.

{}

This appears to only happen to .txt files, I tried with a .log file which is also associated with Notepad++ and that opened fine. Downloading the .txt file then manually double clicking on it in the folder works fine.

Attached is a copy of the dev tools console when the error happens with my access key redacted, line 65 contains the exception that was thrown.

-1524755114343.log

@MRayermannMSFT MRayermannMSFT added the ❔ more info More information is needed from issue author to proceed label Apr 26, 2018
@MRayermannMSFT
Copy link
Member

Hi @leftler , can you try to manually open the file that was downloaded as part of the open process? The path to it appears to be: "C:\Users\SCHAMB~1\AppData\Local\Temp\212…7dd324bb39cca9bae976603ac7f6c_applicationLog.txt".

@leftler
Copy link
Author

leftler commented Apr 26, 2018

Trying to open it from a command prompt I get

Microsoft Windows [Version 10.0.15063]
(c) 2017 Microsoft Corporation. All rights reserved.

U:\>C:\Users\SCHAMB~1\AppData\Local\Temp\2129B3~1\1A9D2D~1\INT-LA~1\2018\04\06\17\AFB338~1.TXT
Access is denied.

U:\>C:\Users\schamberlain\AppData\Local\Temp\2129b340d9871c60427f119d150b1c669de1f9e7d961164d33f65c95c9d3ca23\1a9d2d18a9f75448e4eac03508f7e3d21f78049baffd5a7ca55bad2078f62ccf\INT-LabResultsApi\2018\04\06\17\afb338852ec7227ac269b1f8211ef69976b7dd324bb39cca9bae976603ac7f6c_applicationLog.txt
Access is denied.

Trying to double click the file from explorer also does nothing.

Looking at the permissions on the file show I should have the permissions to open it
image

The ACL definition for the file is

AFB338~1.TXT
D:(A;;FA;;;SY)(A;;FA;;;BA)(A;;FA;;;S-1-5-21-1053782102-1991065663-1845911597-36069)

Copying the file to another location like the desktop allows me to open the file normally. My suspicion is this might be windows disagreeing with the length of the file path. Does %Temp%\2129b340d9871c60427f119d150b1c669de1f9e7d961164d33f65c95c9d3ca23\1a9d2d18a9f75448e4eac03508f7e3d21f78049baffd5a7ca55bad2078f62ccf really need to be that long for a temp folder?

@MRayermannMSFT
Copy link
Member

Can you try opening a text file with a much shorter name? I want to verify that we're looking at a path length issue here before looking at changing that path generation.

@craxal
Copy link
Contributor

craxal commented Jun 25, 2018

Closing this bug as stale. If this continues to be an issue, please let us know, and we can reopen.

@craxal craxal closed this as completed Jun 25, 2018
@redwyre
Copy link

redwyre commented Jul 31, 2018

I'm having problems with the long paths, excel can't seem to handle them (even though the path is less than 255 chars...). I notice the VS Cloud Explorer uses a temp directory directly:

Cloud Explorer, 101 chars
C:\Users\xxxxxxxxxxxxxxx\AppData\Local\Temp\CloudStorage\o3s1pyll.jcm\3b23f3-4456.applicationLog.csv

Storage Explorer, 235 chars
C:\Users\xxxxxxxxxxxxxxx\AppData\Local\Temp\aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\cccccc-test-new\2018\07\31\04\3b23f3-6724.applicationLog.csv

@craxal
Copy link
Contributor

craxal commented Jul 31, 2018

Does Excel open the file if you shorten the file name?

I agree. That's probably an excessively long path for a temp location. @MRayermannMSFT, where do we generate the temp location and how? Is there a way to shorten this?

This page contains some interesting information on path lengths. I notice particularly that character limits should be lifted in Windows 10 (though you have to opt into it somehow).

@MRayermannMSFT
Copy link
Member

MRayermannMSFT commented Jul 31, 2018

Yes, I know where the path is generated. The implementer of the function (it wasn't me! 😋) was trying to make sure the downloaded file would not overwrite one of the same name, but I think they were a bit over zealous...

Anyway, it sounds like @redwyre has confirmed this is a path issue. Let's reopen the bug and try to get it fixed.

@MRayermannMSFT MRayermannMSFT added 🪲 bug Issue is not intended behavior and removed ❔ more info More information is needed from issue author to proceed labels Jul 31, 2018
@redwyre
Copy link

redwyre commented Aug 1, 2018

It does work if I shorten the path. Excel is the party at fault here, but unfortunately that's what I work with

@MRayermannMSFT MRayermannMSFT added this to the 1.7.0 milestone Aug 9, 2018
@MRayermannMSFT MRayermannMSFT added this to Committed in Storage Explorer via automation Dec 4, 2018
@craxal craxal modified the milestones: 1.7.0 Release, 1.6.1 Release Dec 6, 2018
@MRayermannMSFT MRayermannMSFT self-assigned this Dec 7, 2018
@MRayermannMSFT MRayermannMSFT moved this from Committed to In Progress in Storage Explorer Dec 7, 2018
@MRayermannMSFT MRayermannMSFT moved this from In Progress to Under Review in Storage Explorer Dec 7, 2018
@MRayermannMSFT
Copy link
Member

Fix merged into hotfix branch.

Storage Explorer automation moved this from Under Review to Done Dec 7, 2018
@craxal craxal removed this from Done in Storage Explorer Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Issue is not intended behavior
Projects
None yet
Development

No branches or pull requests

4 participants