Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set an empty Expiry time on SAS/ACL dialog #1269

Closed
v-xuanzh opened this issue Apr 3, 2019 · 2 comments
Closed

Allow to set an empty Expiry time on SAS/ACL dialog #1269

v-xuanzh opened this issue Apr 3, 2019 · 2 comments
Assignees
Labels
🪲 regression Issue was working in a previous version ⚙️ sas Related to SAS features 🧪 testing Found through regular testing ✅ merged A fix for this issue has been merged
Milestone

Comments

@v-xuanzh
Copy link

v-xuanzh commented Apr 3, 2019

Storage Explorer Version: 1.7.0_20190401.1
Platform/OS: Linux Ubuntu/macOS High Sierra/Windows 10
Architecture: ia32/x64
Regression From: Previous release 1.7.0

Steps to reproduce:

  1. Right click one account -> Select 'Get Shared Access Signature...'
  2. Set an empty Expiry time on SAS dialog.

Expect Experience:
A red border shows and the 'Create' button is disabled.

Actual Experience:

  1. No error occurs and the 'Create' button is enabled.
  2. Actually, the generated connection string cannot be attached.
    image

More info:
This issue also reproduces on ACL dialog.
image

@v-xuanzh v-xuanzh added 🧪 testing Found through regular testing ⚙️ sas Related to SAS features 🪲 regression Issue was working in a previous version labels Apr 3, 2019
@craxal
Copy link
Contributor

craxal commented Apr 3, 2019

This is a regression? I thought we always required at least an expiry time?

@craxal
Copy link
Contributor

craxal commented Apr 3, 2019

Probably related to fix for #764?

@MRayermannMSFT can you check this out?

@craxal craxal added this to Committed in Storage Explorer via automation Apr 3, 2019
@craxal craxal added this to the 1.8.0 milestone Apr 3, 2019
@MRayermannMSFT MRayermannMSFT moved this from Committed to Under Review in Storage Explorer Apr 11, 2019
@MRayermannMSFT MRayermannMSFT removed their assignment Apr 11, 2019
@craxal craxal moved this from Under Review to In Progress in Storage Explorer Apr 11, 2019
@craxal craxal self-assigned this Apr 11, 2019
@craxal craxal moved this from In Progress to Under Review in Storage Explorer Apr 16, 2019
@craxal craxal moved this from Under Review to In Progress in Storage Explorer Apr 16, 2019
@MRayermannMSFT MRayermannMSFT added the ✅ merged A fix for this issue has been merged label Apr 17, 2019
Storage Explorer automation moved this from In Progress to Done Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 regression Issue was working in a previous version ⚙️ sas Related to SAS features 🧪 testing Found through regular testing ✅ merged A fix for this issue has been merged
Projects
Development

No branches or pull requests

3 participants