Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standard Upload Cannot Upload .app on macOS #1119

Closed
v-xuanzh opened this issue Feb 1, 2019 · 4 comments
Closed

Standard Upload Cannot Upload .app on macOS #1119

v-xuanzh opened this issue Feb 1, 2019 · 4 comments
Assignees
@MRayermannMSFT
Labels
💻 mac Related to macOS platforms 🧪 testing Found through regular testing ✅ merged A fix for this issue has been merged
Projects
Storage Explorer
Milestone
1.9.0

Comments

@v-xuanzh
Copy link

v-xuanzh commented Feb 1, 2019

Storage Explorer Version: 1.6.2/20190201.1
Platform/OS Version: MacOS High Sierra
Architecture: ia32
Commit: f30fe10c
Regression From: Not a regression

Background:

  1. On MacOS, unzip the set up package of Storage Explorer - StorageExplorer-darwin-64.zip.

  2. Open the unzipped folder, it shows the layout as below
    image

  3. Try to upload Microsoft Azure Storage Explorer.app(Actually, it is a directory) to one blob container/file share.

Actual Experience:

  1. We have no way to upload Microsoft Azure Storage Explorer.app as a directory, because it is disabled.
    image
  2. Fail to upload it as a file with the below error.
    image
@v-xuanzh v-xuanzh added 🧪 testing Found through regular testing 💻 mac Related to macOS platforms labels Feb 1, 2019
@MRayermannMSFT MRayermannMSFT self-assigned this Feb 1, 2019
@MRayermannMSFT MRayermannMSFT added this to Committed in Storage Explorer via automation Feb 1, 2019
@MRayermannMSFT MRayermannMSFT added this to the 1.7.0 milestone Feb 1, 2019
@MRayermannMSFT MRayermannMSFT moved this from Committed to Investigating in Storage Explorer Feb 1, 2019
@MRayermannMSFT
Copy link
Member

Yep, definitely not a regression. I'm going to rename this bug to something a little more general, and we'll fix it later.

@MRayermannMSFT MRayermannMSFT modified the milestones: 1.7.0, 1.9.0 Feb 1, 2019
@MRayermannMSFT MRayermannMSFT changed the title Unable to upload the 'Microsoft Azure Storage Explorer.app' on Mac Standard Upload Cannot Upload .app on macOS Feb 1, 2019
@MRayermannMSFT
Copy link
Member

More info:

  • .app files are actually folders
  • when we open the finder on mac though, and ask for folders, .apps are greyed out, so you have to upload them as files
  • this causes the .app file to be treated as a file in our local file query, which means we try to upload it instead of traversing it
  • this causes the node sdk to get upset, and the upload fails

@MRayermannMSFT MRayermannMSFT moved this from Investigating to Committed in Storage Explorer Feb 12, 2019
@MRayermannMSFT MRayermannMSFT moved this from Committed to Blocked in Storage Explorer Apr 11, 2019
@MRayermannMSFT MRayermannMSFT moved this from Blocked to Investigating in Storage Explorer Apr 11, 2019
@MRayermannMSFT MRayermannMSFT moved this from Investigating to Committed in Storage Explorer Apr 12, 2019
@MRayermannMSFT MRayermannMSFT moved this from Committed to Under Review in Storage Explorer May 22, 2019
@MRayermannMSFT
Copy link
Member

Fix merged into master.

Storage Explorer automation moved this from Under Review to Done May 22, 2019
@MRayermannMSFT MRayermannMSFT added ✅ merged A fix for this issue has been merged and removed 🔍 pending labels May 22, 2019
@v-xuanzh
Copy link
Author

Hi @MRayermannMSFT , We are confused about this fixes.

For now, We can upload the .app using 'Upload File' on Upload dialog,
After uploading successfully, The .app shows as a folder.

I think these two behaviors are conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MRayermannMSFT MRayermannMSFT

Labels
💻 mac Related to macOS platforms 🧪 testing Found through regular testing ✅ merged A fix for this issue has been merged
Projects
Storage Explorer
  
Done
Milestone
1.9.0
Development

No branches or pull requests
2 participants
@MRayermannMSFT @v-xuanzh