Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(createParamDecorator): custom param decorators can create Args #1330

Closed
wants to merge 1 commit into from
Closed

feat(createParamDecorator): custom param decorators can create Args #1330

wants to merge 1 commit into from

Conversation

russell-dot-js
Copy link

Fixes #1325

@russell-dot-js russell-dot-js mentioned this pull request Aug 16, 2022
Open
@MichalLytek MichalLytek self-requested a review February 10, 2023 14:17
@MichalLytek MichalLytek added Enhancement 🆕 New feature or request Community 👨‍👧 Something initiated by a community labels Feb 10, 2023
@russell-dot-js
Copy link
Author

@MichalLytek coming up on 1 year old. Thoughts?

@MichalLytek
Copy link
Owner

I like the idea but I see some tweaks needed in the implementation. Will take a look at that after #1400 👀

@MichalLytek MichalLytek mentioned this pull request Apr 24, 2024
Open
@MichalLytek MichalLytek mentioned this pull request May 3, 2024
Open
@MichalLytek
Copy link
Owner

Thanks @russell-dot-js for your contribution! ❤️

Sorry that I took me so long to take care of this PR.
Unfortunately, because of conflicts made by #1400 and lack of required permissions to push the conflict resolution commit to your repo, I had to reimplement those changes with some tweak and additions in a new PR #1680, so I have to close this one 🔒

@MichalLytek MichalLytek closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalLytek MichalLytek Awaiting requested review from MichalLytek MichalLytek is a code owner

Assignees

@russell-dot-js russell-dot-js

Labels
Community 👨‍👧 Something initiated by a community Enhancement 🆕 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Param Decorator breaks other @Arg if not last argument
2 participants
@russell-dot-js @MichalLytek