Draft: nix-darwin module #558
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is somewhat but not entirely duplicative with the home manager support. The difference is primarily for MacOS servers, for which there is no LaunchAgent support (as launch agents are tied to user sessions). This PR adds a nix-darwin module (configured similarly to the home manager module) which is suitable for e.g. other launchd daemons.
aymanbagabas
approved these changes
May 5, 2024
Mic92
reviewed
May 9, 2024
| description = '' | ||
| Path where secrets are symlinked to. | ||
| If the default is kept no other symlink is created. | ||
| `%r` is replaced by $XDG_RUNTIME_DIR on linux or `getconf |
There was a problem hiding this comment.
This does not exist on macos, right?
Mic92
reviewed
May 9, 2024
|
|
||
| defaultSecretsMountPoint = lib.mkOption { | ||
| type = lib.types.str; | ||
| default = "%r/secrets.d"; |
Mic92
reviewed
May 9, 2024
| options.sops = { | ||
| logFile = lib.mkOption { | ||
| type = lib.types.path; | ||
| default = "/var/log/sops.log"; |
There was a problem hiding this comment.
Do applications need to log themselves to files?
Automatic tests in the CI would be great, but I don't know how this is done on macOS. I do have a macos builder in buildbot, if that helps.
I don't think we need to butcher the nixos options to share them between platforms.
Yes, would be. I assume it's not that different from other platforms?
|
Mic92
reviewed
May 9, 2024
| ''; | ||
| }; | ||
|
|
||
| mode = lib.mkOption { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #409.
The home manager module covers most cases on Darwin, but does not cover headless devices as agents don't run unless a user session exists. This is a (draft) small copy-paste job of the home-manager integration which is enough to get nix-darwin working.
I'd like feedback on:
and honestly anything else.