Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"<svg/" not throwing a parser error #601

Open
MewPurPur opened this issue Mar 18, 2024 · 1 comment
Open

"<svg/" not throwing a parser error #601

MewPurPur opened this issue Mar 18, 2024 · 1 comment
Labels
bug not our fault The issue is caused by a bug in Godot or ThorVG

Comments

@MewPurPur
Copy link
Owner

MewPurPur commented Mar 18, 2024 •
edited

Some XMLs that should probably be throwing an error. At least some of them are caused by issues in Godot's XMLParser:

  • <svg/
  • <svg><svg >
  • <42></42>
@MewPurPur MewPurPur added the bug label Mar 18, 2024
@MewPurPur
Copy link
Owner Author

MewPurPur commented Mar 19, 2024 •
edited

EDIT: Fixed on our side.

Somewhat relevant: godotengine/godot#89668

But if that's addressed, there is still a bug on our side, because <svg> also should throw a parser error.

Entirely at fault: godotengine/godot#89668

@MewPurPur MewPurPur mentioned this issue Mar 19, 2024
Merged
@MewPurPur MewPurPur changed the title "<svg" not throwing a parser error. "<svg/" not throwing a parser error Mar 19, 2024
@MewPurPur MewPurPur added the not our fault The issue is caused by a bug in Godot or ThorVG label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug not our fault The issue is caused by a bug in Godot or ThorVG
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MewPurPur