Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidify the implementation of adding new objects #496

Open
MewPurPur opened this issue Feb 14, 2024 · 1 comment
Open

Solidify the implementation of adding new objects #496

MewPurPur opened this issue Feb 14, 2024 · 1 comment
Labels

Comments

@MewPurPur
Copy link
Owner

MewPurPur commented Feb 14, 2024

Concerns #395, #484

Adding new objects would be one of two things:

  • Adding new tag paths after RMB in the viewport
  • Inserting new path commands after RMB in the viewport or using the shortcuts

We need some special logic for adding tags or path commands at a position, the regular logic won't do:

  • Adding a new line at (x,y) should make it so the second handle is at (x + 1, y)
  • Adding a new curve path command at should generate the control points between the start and the end, similar to how Convert To currently behaves.

Moreover, this special logic needs to run every frame. Seemingly, we'll need to implement a temporary_add() kind of function in a lot of places, one that doesn't concern UndoRedo, but that still updates the text, until the object is really added at the end.

When it comes to cancelling these changes, I believe what we actually need is to solidify some logic for cancelling actions, which needs its own proposal.

@MewPurPur MewPurPur self-assigned this Feb 18, 2024
@MewPurPur
Copy link
Owner Author

Would be really good to get this right before the next alpha.

@MewPurPur MewPurPur removed their assignment May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant