-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reduce size of token list fetch #24316
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24316 +/- ##
========================================
Coverage 67.34% 67.34%
========================================
Files 1282 1282
Lines 50065 50065
Branches 12986 12986
========================================
Hits 33716 33716
Misses 16349 16349 ☔ View full report in Codecov by Sentry. |
Hmmm the e2e tests failing in CI are passing locally |
I'm confused by the e2e test failures. They keep passing locally in both browsers, and should be unrelated to the changes.
But not in CI for some reason? |
Builds ready [da392d5]
Page Load Metrics (1229 ± 614 ms)
Bundle size diffs
|
Description
When switching to a network for the first time, MM checks whether a token list is available for the network. If not, the 3rd item is shown here:
But we don't need the entire token list, since we're only checking whether a list is available. Adding query parameters to reduce the response size. On mainnet for example, 1.5MB (gzipped) to < 1KB.
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist