Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Multichain: Set useRequestQueue on by default #23985

Closed
9 tasks
darkwing opened this issue Apr 11, 2024 · 0 comments · Fixed by #24274
Closed
9 tasks

UX: Multichain: Set useRequestQueue on by default #23985

darkwing opened this issue Apr 11, 2024 · 0 comments · Fixed by #24274
Assignees
Labels
amon-hen-v1 Represents blocking issues for the release of Amon Hen release-11.18.0 Issue or pull request that will be included in release 11.18.0 team-wallet-ux

Comments

@darkwing
Copy link
Contributor

What is this about?

Before we release Amon Hen, we must turn on the useRequestQueue setting for all users. To turn on the setting for all users while keeping the toggle, we'll need to write a migration to migrate the value to true.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

@darkwing darkwing added the amon-hen-v1 Represents blocking issues for the release of Amon Hen label Apr 11, 2024
@hesterbruikman hesterbruikman removed their assignment Apr 25, 2024
@metamaskbot metamaskbot added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 6, 2024
NidhiKJha added a commit that referenced this issue May 8, 2024
This PR is to ensure that `useRequestQueue` is set to `true` by default.
After setting it to true, it turn the setting on for all users while
keeping the toggle, since this is a state update. This PR also includes
a migration.

## **Related issues**

Fixes: #23985 

## **Manual testing steps**

1. Go to settings > Experimental
2. Check `Select networks for each site` toggle is on
3. Toggle should work properly

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**


![Screenshot 2024-04-29 at 12 43
31 PM](https://github.com/MetaMask/metamask-extension/assets/39872794/6bdc6f49-6f20-44f1-a063-f9edd1dba09b)

### **After**

![Screenshot 2024-04-29 at 12 43
03 PM](https://github.com/MetaMask/metamask-extension/assets/39872794/19fce2fa-d0cb-43b8-8731-7b64c6d33975)



## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Alex <adonesky@gmail.com>
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 8, 2024
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amon-hen-v1 Represents blocking issues for the release of Amon Hen release-11.18.0 Issue or pull request that will be included in release 11.18.0 team-wallet-ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants