Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The icons for certain networks may not be appearing as expected in the popup header and on the toast notifications #24255

Closed
sleepytanya opened this issue Apr 26, 2024 · 0 comments · Fixed by #24258
Assignees
Labels
amon-hen-v1 Represents blocking issues for the release of Amon Hen release-11.17.0 Issue or pull request that will be included in release 11.17.0 Sev3-low Low severity; minimal to no impact upon users team-wallet-ux type-bug

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

The icons for certain networks may not be appearing as expected in the popup header and on the toast notifications. List of networks with missing icon:

  • Boba BNB
  • Boba network
  • Zeta chain
  • Scroll
  • ThunderCore
  • Blast
  • BitTorrent Chain
  • Kava
  • Base
  • Metis
  • opBNB
  • zkSync Era

Expected behavior

Screenshots/Recordings

Screenshot 2024-04-25 at 17 47 52 Screenshot 2024-04-25 at 14 07 37

Steps to reproduce

  1. Connect to dApp
  2. Switch to any network from the list above
  3. Open popup in the dApp with selected network
  4. See the network icon is not shown

Error messages or log output

No response

Version

amon-hen-v1

Build type

None

Browser

Chrome, Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added type-bug team-wallet-ux amon-hen-v1 Represents blocking issues for the release of Amon Hen labels Apr 26, 2024
@gauthierpetetin gauthierpetetin added the Sev3-low Low severity; minimal to no impact upon users label Apr 26, 2024
@NidhiKJha NidhiKJha self-assigned this Apr 29, 2024
NidhiKJha added a commit that referenced this issue May 2, 2024
For some of the networks where favicon wasn't there, we rendered `?` for
the avatar network logo in dapp toast. This PR fix this issues and adds
a fallback to the network name when image is not there

## **Related issues**

Fixes: #24255 

## **Manual testing steps**

1. Run extension with Multichain flag
2. Connect to a uniswap
3. Switch network to Blast on dapp. Check the toast and that network
logo should be same as popup header

## **Screenshots/Recordings**


### **Before**
![Screenshot 2024-04-26 at 4 52
48 PM](https://github.com/MetaMask/metamask-extension/assets/39872794/118a442b-c3b6-4fc7-846a-7a031f2ad284)


### **After**
![Screenshot 2024-04-26 at 4 43
17 PM](https://github.com/MetaMask/metamask-extension/assets/39872794/c36ca839-6f88-403f-9a3e-704d9028c5c2)


## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
@metamaskbot metamaskbot added the release-11.17.0 Issue or pull request that will be included in release 11.17.0 label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amon-hen-v1 Represents blocking issues for the release of Amon Hen release-11.17.0 Issue or pull request that will be included in release 11.17.0 Sev3-low Low severity; minimal to no impact upon users team-wallet-ux type-bug
Projects
Archived in project
Status: Fixed
Development

Successfully merging a pull request may close this issue.

4 participants