Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: eth_getTransactionCount with a bad address gives "network does not support ENS" error #24246

Open
shanejonas opened this issue Apr 25, 2024 · 1 comment
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. team-wallet-api-platform type-bug

Comments

@shanejonas
Copy link
Contributor

shanejonas commented Apr 25, 2024

Describe the bug

When providing a bad address, eth_getTransactionCount errors with an error message about not supporting ENS.

Expected behavior

Ideally this should error with invalid address

Screenshots/Recordings

No response

Steps to reproduce

  1. see test output here: https://output.circle-artifacts.com/output/job/bffd2656-2b53-48e0-b110-bc0437fd8100/artifacts/0/html-report/index.html#/details/46

Error messages or log output

request

{
  "id": 46,
  "jsonrpc": "2.0",
  "method": "eth_getTransactionCount",
  "params": [
    "0x0Bc,e74408D1f8Cb8B67FED245,18f3aDAd00292",
    "pending"
  ]
}

response

{
  "id": 46,
  "jsonrpc": "2.0",
  "error": {
    "code": -32603,
    "data": {
      "originalError": {
        "code": "UNSUPPORTED_OPERATION",
        "network": "unknown",
        "operation": "getResolver",
        "reason": "network does not support ENS"
      }
    },
    "message": "network does not support ENS (operation=\"getResolver\", network=\"unknown\", code=UNSUPPORTED_OPERATION, version=providers/5.7.2)"
  }
}

Version

sj/api-spec-tests

Build type

Other (please specify exactly where you obtained this build in "Additional Context" section)

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

test build on sj/api-spec-tests

Severity

No response

@shanejonas shanejonas changed the title [Bug]: eth_getTransactionCount with a bad address gives weird "network does not support ENS" error [Bug]: eth_getTransactionCount with a bad address gives "network does not support ENS" error Apr 25, 2024
@gauthierpetetin gauthierpetetin added the Sev2-normal Normal severity; minor loss of service or inconvenience. label Apr 26, 2024
@vandan
Copy link

vandan commented May 3, 2024

Relates to: #14822
Didn't make the change mainly due to lack of procedures for dev outreach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. team-wallet-api-platform type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

3 participants