Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an geographer-nl #26

Open
gaetan-petit opened this issue Nov 22, 2018 · 9 comments
Open

Provide an geographer-nl #26

gaetan-petit opened this issue Nov 22, 2018 · 9 comments

Comments

@gaetan-petit
Copy link

Hello,

We'd like to integrate Geographer in our solution, is there any way you could provide a package for dutch ?
Or describing how we could gather and package data on our own ?

Thank you.

@dusterio
Copy link
Member

@gaetan-petit we would be glad if somebody added an extra language (Dutch in this case)
You could take Geonames free database as a starting point - take whatever translations are already there, and then improve it gradually?

@gaetan-petit
Copy link
Author

@dusterio I'm not familiar with Geonames, did you extract the data from there with a script ? Or are you suggestion forking geographer-data and reviewing all the data by hand (doable but that would be a massive amount of work).

@gaetan-petit
Copy link
Author

@dusterio could you create a geographer-nl repo for us and add nl locale in geographer main repository?
Thank you.

@gaetan-petit
Copy link
Author

@dusterio Do you think you can do that? At least give me an answer so we could react on our side.

@dusterio
Copy link
Member

@gaetan-petit I created a new repo https://github.com/MenaraSolutions/geographer-nl - I will fill it with publicly available translations (geonames) tomorrow, but then you will probably need to make some fixes via pull requests :))

@gaetan-petit
Copy link
Author

Awesome 🎊 Thank you @dusterio !

We will, we started to gather some data about state names in dutch and we will provide them via PR.
I think you also have to make a change to the main repo to make nl available too, right ?

@dusterio
Copy link
Member

@gaetan-petit I added the language to the main package ("geographer") as well, and geographer-nl has an example of country list. Whenever you can update the translations - I'll merge it quickly :)

@gaetan-petit
Copy link
Author

@dusterio thank you again.
Could you provide the states list as well ?
We will try to fill it asap.

@gaetan-petit
Copy link
Author

Hello @dusterio I think my message went unnoticed, could you also populate the states list ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants