New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getCode method for city instance return geoname instead of iso_3166_2 #20

Open

raftalks opened this issue Jun 19, 2017 · 1 comment

raftalks commented Jun 19, 2017

The data does provides ids. iso_3166_2 but in the city class, both geonames and the code is the same value.

https://github.com/MenaraSolutions/geographer/blob/master/src/City.php#L25

Member

dusterio commented Jun 19, 2017

At the moment Geonames Id is the only public/third-party identification for cities. ISO doesn't issue city codes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment