Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run linter on pre-commit hook #84

Open
jazcarate opened this issue Apr 9, 2022 · 5 comments
Open

Run linter on pre-commit hook #84

jazcarate opened this issue Apr 9, 2022 · 5 comments

Comments

@jazcarate
Copy link
Collaborator

I'm very bad at running prettier, and there is a very easy way to hook it to the git pre-commit in both server/ and client/

https://prettier.io/docs/en/precommit.html

@jazcarate
Copy link
Collaborator Author

Additionally, I think there are a lot of files in client/component are not formatted

@MaxLeiter
Copy link
Owner

MaxLeiter commented Apr 10, 2022

Additionally, I think there are a lot of files in client/component are not formatted

Thanks, I forgot to lint tsx files. Pushed.

@jazcarate
Copy link
Collaborator Author

😅 Ok this might be tricker than expected, as it is one repo with multiple projects, none of the out of the box solutions with Husky will work.
I'll leave this issue as is, but I think we'll just close it and be more vigilant 🙈

@MaxLeiter
Copy link
Owner

I can look into writing a custom hook, iirc its really just a bash script

@jazcarate
Copy link
Collaborator Author

Yup. But I'm on Windows atm 🙈
So it wouldn't fix my inability to remember to run the linter 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants