Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Refit to generate API calls #54

Open
1 of 2 tasks
Matthiee opened this issue Aug 10, 2022 · 7 comments
Open
1 of 2 tasks

Use Refit to generate API calls #54

Matthiee opened this issue Aug 10, 2022 · 7 comments
Assignees
@tforsberg
Labels
Breaking Introduces breaking changes enhancement New feature or request help wanted Extra attention is needed

Comments

@Matthiee
Copy link
Member

Matthiee commented Aug 10, 2022 •
edited

@Matthiee Matthiee added enhancement New feature or request help wanted Extra attention is needed Breaking Introduces breaking changes labels Aug 10, 2022
@Matthiee Matthiee self-assigned this Aug 15, 2022
@Matthiee Matthiee changed the title Investigate Refit Use Refit to generate API calls Aug 15, 2022
@tforsberg
Copy link
Contributor

I will try to implement this. I have reviewed Refit and it looks VERY impressive.

@Matthiee
Copy link
Member Author

Matthiee commented Oct 1, 2022

@tforsberg Sounds good!

@Matthiee Matthiee assigned tforsberg and unassigned Matthiee Oct 1, 2022
@tforsberg
Copy link
Contributor

I created a branch called "Refit" in my fork. Can I remove the .NET 5 support in this project?

@Matthiee
Copy link
Member Author

Matthiee commented Oct 3, 2022

If possible I would like to keep both for now. Is there something that doesn't work in .NET 5 regarding refit?

@tforsberg
Copy link
Contributor

tforsberg commented Oct 3, 2022 •
edited

No. It should all work in .NET 5 also.

The reason I'd like to use .NET 6 only is there are several improvements in the C# version 10 language.
https://learn.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-10

.NET 5 uses C# version 9
.NET 6 uses C# version 10

@Matthiee
Copy link
Member Author

Matthiee commented Oct 3, 2022

You can remove the .NET 5 support.

@tforsberg
Copy link
Contributor

tforsberg commented Oct 3, 2022 via email •
edited

@tforsberg tforsberg mentioned this issue Oct 3, 2022
Closed
tforsberg added a commit to tforsberg/MatthiWare.FinancialModelingPrep.NET that referenced this issue Oct 3, 2022
@tforsberg
Issue MatthiWare#54
eef4ae9 
-Updated packages
-Added .NET 7 target
-Dropped .NET 5 target
-Added console app project for testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tforsberg tforsberg

Labels
Breaking Introduces breaking changes enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tforsberg @Matthiee