Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider lowering strictness of domain and path values #36

Open
CasperWA opened this issue Sep 17, 2020 · 1 comment
Open

Consider lowering strictness of domain and path values #36

CasperWA opened this issue Sep 17, 2020 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@CasperWA
Copy link
Member

Raised as a comment in #34 by @ml-evs, we may want to loosen the strictness of how to pass in the values of domain and especially path.

At the moment one MUST prepend path with a / and MUST NOT append a / to the domain value.

Pro: Errors from passing incorrectly formatted values, which may be unclear, are avoided.
Con: This will lead to several, if not a lot of, prep-/appended / to determine the "correct" URL.

@CasperWA CasperWA added enhancement New feature or request question Further information is requested labels Sep 17, 2020
@CasperWA
Copy link
Member Author

Suggestion: Use the Python "helper.py" introduced in #42 to conduct these checks quick and dirty, retrieving a complete URL in the shell script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant