New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to support netstandard #909
Comments
I'm looking at |
Personally only stable packages should be referenced since that would bring the end users version up to beta and might break their existing logging. |
I thought Autofac had a netstandard build as well |
@phatboyg it does target netstandard1.1 in 4.6.0 https://www.nuget.org/packages/Autofac/4.6.0 |
Finished |
I could take a look at EF persistence. |
I can port MassTransit.SimpleInjectorIntegration and MassTransit.Reactive projects. |
I had previously implemented an integration for |
@stromblom I do wonder if there will need to be a new proj for EFCore for persistence so people using EF6 can keep using that. |
@andymac4182 Yeah probably. But that's cool. Ill take a look. |
@stromblom Hopefully its just a copy paste and change of reference. |
@phatboyg Do you have a preference on which projects are a minimum set of projects required for a preview/release? |
Updated to show some of the packages that can't be upgraded currently due to dependencies. If anyone is aware of any extra ones or if I made a mistake please let me know 😄 |
Before a real .NET Core release, I'd like |
No worries. I believe all of those are now either submitted or merged. |
The last major thing I am not sure about is how to get the test running against both netcore and full framework. Does anyone have a good way of doing this? |
It appears as the DocumentDb client has two nuget packages now https://www.nuget.org/packages/Microsoft.Azure.DocumentDB/ https://www.nuget.org/packages/Microsoft.Azure.DocumentDB.Core/ |
Can packages be conditional based upon target framework? |
Yeh they can. @phatboyg We could compile against each package for the different targets. |
Looks like |
I have |
PR #920 created for this ^^. After this is merged, all logging and IoC should be ported that can be. |
Is there anything else that people would like to see supported in the initial release? It is good to see such a good list of projects that support netstandard now. |
@andymac4182 as I have mentioned here scheduling support will be great. |
You can use the Quartz packages in full framework where Quartz is currently supported. Once Quartz is supported on core in non pre-release I am sure it will be updated. |
For those who come across this the Nuget feed URI is |
The library is significantly different and the management library is still missing important properties for queues and topics. |
Quartz.NET beta 1 has .NET Standard 2 support https://www.quartz-scheduler.net/2017/10/08/quartznet-3.0-beta1-released.html |
@MrZoidberg It does, but I think the idea for migration is not to take dependencies on pre-release packages. |
@jacobpovar sure. I've compiled the MT with Quartz.NET beta 1 and will explore how does it work with in my project. |
@MrZoidberg - have you had any issues with .net core support for quartz with MT? |
@dekelMP I'm still using MT with quartz in that way and haven't found any problems so far. but I'm not using any persistence for quartz |
@alexeyzimarev Any updates on ASB for MT supporting .net standard 2.0? |
@Remedij I have a branch using the new .NET compatible assemblies, but it isn't done yet. The microsoft assemblies are all preview versions, so it needs to get a little more real before I can release anything. |
@phatboyg Well, great news! We would really like to use MT on new .net core project, is it possible to share an estimation (even for preview)? Or should we rather consider something else? Thank you! |
It will be there at some point. I can't promise a date though. You can develop and test on regular .NET. |
@Remedij Chris started a new thing after heavy refactoring, I gave up rebasing the changes in topology. |
And I've gutted more Of the internals to reduce complexity. Should be committing changes this weekend. |
@phatboyg is the source code available for .Net Core 2.0? Please provide us the link. Thanks. |
@dtssomak source code of what. if I may ask? |
Tried all this out and seemed to work without a hitch! Great job so far. |
It should :) |
Source code for MassTransit .Net core. I know its available on nuget as package for .net Core, but I wanted the source. The ne that is already available in Github is for .net 4.5.2
It would be great if you can provide me for .net core 2.0
…Sent from my Windows 10 phone
From: Alexey Zimarev
Sent: 19 February 2018 08:07 PM
To: MassTransit/MassTransit
Cc: dtssomak; Mention
Subject: Re: [MassTransit/MassTransit] Migration to support netstandard (#909)
@dtssomak source code of what. if I may ask?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@dtssomak You can find the tags the NuGet packages were built from on this very site, in fact, here is the latest tag for v4.0.1 |
Any update on quartz? Is it part of the development releases? I am looking to use it this sprint. Thanks. |
Quartz already supports .NET Standard, and MT support was released as well: |
The Azure Service Bus transport changes to support .NET Core are in progress, but lacking support for NET 4.5.2 means this would have to be a separate transport to avoid breaking those using the current ASB support. Ugh.. Anyway, this branch: https://github.com/phatboyg/MassTransit/tree/net-core-asb |
In the next few months, yes. Just not today. It's a harder than I thought
thing, considering it's an entirely new library structure.
…On Sun, Mar 11, 2018 at 3:21 PM, Paul VanRoosendaal < ***@***.***> wrote:
I realize Azure Service Bus Transport support is more involved. Are you
looking to release an update(.NET Std 2.0) for this in the next few months?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#909 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABOSax2NVayanMQOoQyUg2O3C5BcaNUks5tdYc4gaJpZM4N5SPD>
.
|
is there any saga Storage Engines for .net standard? |
EF store is not migrated, EF.Core store should be used instead, for obvious reasons. All other stores are migrated. |
I'm going to close this issue, and open a new one for the new Azure transport I'm nearly finished building. There will be two transports, one for legacy net452 (existing) and a new one for netstandard. |
MassTransit.NinjectIntegration (Not currently supported https://www.nuget.org/packages/Ninject/4.0.0-beta-0134)MassTransit.NLogIntegration (Not currently supported in non beta https://www.nuget.org/packages/NLog/5.0.0-beta07)MassTransit.AzureServiceBusTransport.TestsMassTransit.AzureServiceBusTransport (Not currently supported https://www.nuget.org/packages/Microsoft.WindowsAzure.ConfigurationManager/ https://www.nuget.org/packages/WindowsAzure.ServiceBus/)MassTransit.EntityFrameworkIntegration (Needs new project to support EFCore)MassTransit.NHibernateIntegration (Not currently supported https://www.nuget.org/packages/NHibernate/)The text was updated successfully, but these errors were encountered: