Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback route should be evaluated at the end #786

Open
1 task
eaguad1337 opened this issue Jan 8, 2024 · 0 comments · May be fixed by #787
Open
1 task

Fallback route should be evaluated at the end #786

eaguad1337 opened this issue Jan 8, 2024 · 0 comments · May be fixed by #787
Labels
enhancement

Comments

@eaguad1337
Copy link
Member

Is your feature request related to a problem?

Routes are evaluated in order and if you have a Route.fallback() before more routes, these routes will never be evaluated.

What do we currently have to do now?

No response

Describe the solution you'd like

Make Route.fallback to be evaluated at the end.

Describe alternatives you've considered

No response

Would this be a breaking change ?

  • Yes

Anything else ?

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: force fallback route to be evaluated at the end eaguad1337/masonite
1 participant
@eaguad1337