Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tray Icon remains green when remote device is disconnected #248

Open
1 of 6 tasks
Lcchy opened this issue Apr 10, 2024 · 4 comments
Open
1 of 6 tasks

Tray Icon remains green when remote device is disconnected #248

Lcchy opened this issue Apr 10, 2024 · 4 comments

Comments

@Lcchy
Copy link

Lcchy commented Apr 10, 2024

Relevant components

  • Standalone tray application (based on Qt Widgets)
  • Plasmoid/applet for Plasma desktop
  • Dolphin integration
  • Command line tool (syncthingctl)
  • Integrated Syncthing instance (libsyncthing)
  • Backend libraries

Environment and versions

  • Version of syncthingtray: 1.5.1
  • Operating system (name and version): Fedora 39

Bug description
When I shutdown the remote device ("linode" in the screenshot), syncthingtray, which is running on my pc ("lemur") , detects that the device is disconnected but the tray icon does not turn grey.

Expected behavior
The tray icon turns grey to reflect the connection loss.

Screenshots
screenshot_2024-Apr-10th_19h07m11s

When I pause the device from my pc, the tray icon behaves as expected:
screenshot_2024-Apr-10th_19h17m03s

Ps: I would also like to receive a desktop notification about the connection loss, even though I have setup all notifications in the settings, that is not the case. Is this possible?

I am new to syncthingtray, and I hope that I have not simply overlooked some setting regarding my issue.

@Lcchy Lcchy added the bug label Apr 10, 2024
@Martchus
Copy link
Owner

It behaves actually as expected. I could add a setting to allow changing the behavior in the way you described. Should it turn gray if at least one remote is not connected or only if all remotes are not connected?

Adding a notification would also be possible.

Not sure when I'll find the time to implement this but I'd accept a PR. Just make sure the default behavior stays.

@Lcchy
Copy link
Author

Lcchy commented Apr 10, 2024

Ah I see, thanks for the quick reply!

In my use case it would make more sense for it to turn grey if at least one remote is disconnected.

I will look into the code and see if it seems doable for me to write a PR.

@Martchus
Copy link
Owner

If it is doable then let me know if you start coding so we're not duplicating the effort. (I'll also assign myself to this issue on GitHub when I'll find the time to work in it myself.)

@Lcchy
Copy link
Author

Lcchy commented Apr 15, 2024

Hi! Sorry I am having a busy time, I have looked at the code but I don't have enough time at the moment to be able to take it on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants