Getting the View for an Image in a quote post #119

Scrxtchy · 2023-07-27T03:12:05Z

Scrxtchy
Jul 27, 2023

I've had this problem for a while and had it swept under the rug for a while. I still cannot think of a solution to this.
When retrieving a post though feed.getposts() if the post has an image, but the post has an embed of another record, the images in the maid record as returned with the type of app.bsky.embed.images#image, which is in contrast to when the Post does not have a record embed, it includes the app.bsky.embed.images#view in the embeds, giving back the impageproxy urls for the media.

I am confused as to why this has happened, as when looking at the network requests on the website, the app.bsky.embed.recordWithMedia#view record type contains both a app.bsky.embed.record#viewRecord to contain the record of the quoted post, as well as the app.bsky.embed.images#view images containing the urls that I have been seeking out

Answered by Scrxtchy

Jul 27, 2023

EDIT: this is a type problem (explained below)

I've solved the issue, but it's... it's shocking
https://github.com/MarshalX/atproto/blob/main/atproto/xrpc_client/models/app/bsky/feed/defs.py#L25-L33

I moved 'models.AppBskyEmbedRecordWithMedia.View' to the top of the list, and it started filling out the data correctly

View(media=View(images=[ViewImage(alt='',
                                  fullsize='https://cdn.bsky.social/imgproxy/-msLgPXc7BkLB84gVN6iCUIR7CHOoXdbTkD6YpCeFZY/rs:fit:2000:2000:1:0/plain/bafkreif2blhvgss23kj2lqi6b6qkb6jqnz3zze6mvyvh7argmhpealzlw4@jpeg',
                                  thumb='https://cdn.bsky.social/imgproxy/f_aTws11I8nONbB0qlIQ5eXHEFvaLELJqTN_4T2v_FY/rs:…

View full answer

MarshalX · 2023-07-27T06:56:55Z

MarshalX
Jul 27, 2023
Maintainer

Hi! Could you please provide code snippet with the real ids to reproduce?

17 replies

MarshalX Jul 27, 2023
Maintainer

sorry, I understand enough what is the problem. what information between plain server response and data models was missed? :(

Scrxtchy Jul 27, 2023
Author

changed the code to test this

client = Client()
client.login(os.environ['USERNAME'], os.environ['PASSWORD'])

post_uri = 'at://did:plc:hbtuqflamm5j2i7yahtzsnue/app.bsky.feed.post/3k3ic43ucbq2f'
post = client.bsky.feed.get_post_thread({'uri' : uri, 'depth':1, 'parentHeight':0}).thread.post
print(post.embed)

media object in the post embed object still missing, still only keeping the record embed

Output

View(record={'record': {'$type': 'app.bsky.embed.record#viewRecord',
                        'uri': 'at://did:plc:z2rokxrttw5254hogmucux2x/app.bsky.feed.post/3k3hbh6k7752z',
                        'cid': 'bafyreicutqwniezgehk7ie3vxjtkiwyv73oxgqczqpinn6tgf2lq7x32eu',
                        'author': {'did': 'did:plc:z2rokxrttw5254hogmucux2x',
                                   'handle': 'lookitup.baby',
                                   'displayName': 'Ian Coldwater',
                                   'avatar': 'https://cdn.bsky.social/imgproxy/g8exglxR_oanrR1eq-wK_ukYq-SC8_i3dh8td7m0qIQ/rs:fill:1000:1000:1:0/plain/bafkreif7zcepr4rrg3o4gctttycvbklypxvzlpsfd7y4bo2bkixrvdafv4@jpeg',
                                   'viewer': {'muted': False,
                                              'blockedBy': False},
                                   'labels': []},
                        'value': {'text': '*David Attenborough voice* the '
                                          'young sharks gather in the spawning '
                                          'grounds, waiting for the dolls to '
                                          'find them',
                                  '$type': 'app.bsky.feed.post',
                                  'embed': {'$type': 'app.bsky.embed.images',
                                            'images': [{'alt': 'a large pile '
                                                               'of BLÅHAJ ',
                                                        'image': {'$type': 'blob',
                                                                  'ref': {'$link': 'bafkreih7blzl33qe3brghoga6fzb6gq4xhglagiqepyfq6wskdrinx24am'},
                                                                  'mimeType': 'image/jpeg',
                                                                  'size': 954723}}]},
                                  'langs': ['en'],
                                  'createdAt': '2023-07-26T20:40:05.511Z'},
                        'labels': [],
                        'indexedAt': '2023-07-26T20:40:05.664Z',
                        'embeds': [{'$type': 'app.bsky.embed.images#view',
                                    'images': [{'thumb': 'https://cdn.bsky.social/imgproxy/K3d3SITTqfkLUvwD4C7Rs1MPu3aGb-ICL7r0W-YKusA/rs:fit:1000:1000:1:0/plain/bafkreih7blzl33qe3brghoga6fzb6gq4xhglagiqepyfq6wskdrinx24am@jpeg',
                                                'fullsize': 'https://cdn.bsky.social/imgproxy/iNqiuE5n5M6mWXkP-1S-eZHk_9kvlu822yv7YX1adPc/rs:fit:2000:2000:1:0/plain/bafkreih7blzl33qe3brghoga6fzb6gq4xhglagiqepyfq6wskdrinx24am@jpeg',
                                                'alt': 'a large pile of '
                                                       'BLÅHAJ '}]}]}},
     _type='app.bsky.embed.record#view')

get request

https://bsky.social/xrpc/app.bsky.feed.getPostThread?uri=at%3A%2F%2Fdid%3Aplc%3Ahbtuqflamm5j2i7yahtzsnue%2Fapp.bsky.feed.post%2F3k3ic43ucbq2f

{
	"thread":
	{
		"$type": "app.bsky.feed.defs#threadViewPost",
		"post":
		{
			"uri": "at://did:plc:hbtuqflamm5j2i7yahtzsnue/app.bsky.feed.post/3k3ic43ucbq2f",
			"cid": "bafyreib7whej6tn7aoqwqgm6upautwbcgasshnr7dqdx6bxzpfyyn6nezi",
			"author":
			{
				"did": "did:plc:hbtuqflamm5j2i7yahtzsnue",
				"handle": "raven.corvids.club",
				"displayName": "raven",
				"avatar": "https://cdn.bsky.social/imgproxy/82ndzeXY00rb0aGIALOrc6g5Js2b_snjFD7m-sxVEmU/rs:fill:1000:1000:1:0/plain/bafkreiflgjysr2jrq7a22iptzj56x7bkp5wsgqncs4oepvxnnunndzzrhe@jpeg",
				"viewer":
				{
					"muted": false,
					"blockedBy": false
				},
				"labels":
				[]
			},
			"record":
			{
				"text": "",
				"$type": "app.bsky.feed.post",
				"embed":
				{
					"$type": "app.bsky.embed.recordWithMedia",
					"media":
					{
						"$type": "app.bsky.embed.images",
						"images":
						[
							{
								"alt": "",
								"image":
								{
									"$type": "blob",
									"ref":
									{
										"$link": "bafkreif2blhvgss23kj2lqi6b6qkb6jqnz3zze6mvyvh7argmhpealzlw4"
									},
									"mimeType": "image/jpeg",
									"size": 282975
								}
							}
						]
					},
					"record":
					{
						"$type": "app.bsky.embed.record",
						"record":
						{
							"cid": "bafyreicutqwniezgehk7ie3vxjtkiwyv73oxgqczqpinn6tgf2lq7x32eu",
							"uri": "at://did:plc:z2rokxrttw5254hogmucux2x/app.bsky.feed.post/3k3hbh6k7752z"
						}
					}
				},
				"langs":
				[
					"en"
				],
				"createdAt": "2023-07-27T06:24:25.696Z"
			},
			"embed":
			{
				"$type": "app.bsky.embed.recordWithMedia#view",
				"record":
				{
					"record":
					{
						"$type": "app.bsky.embed.record#viewRecord",
						"uri": "at://did:plc:z2rokxrttw5254hogmucux2x/app.bsky.feed.post/3k3hbh6k7752z",
						"cid": "bafyreicutqwniezgehk7ie3vxjtkiwyv73oxgqczqpinn6tgf2lq7x32eu",
						"author":
						{
							"did": "did:plc:z2rokxrttw5254hogmucux2x",
							"handle": "lookitup.baby",
							"displayName": "Ian Coldwater",
							"avatar": "https://cdn.bsky.social/imgproxy/g8exglxR_oanrR1eq-wK_ukYq-SC8_i3dh8td7m0qIQ/rs:fill:1000:1000:1:0/plain/bafkreif7zcepr4rrg3o4gctttycvbklypxvzlpsfd7y4bo2bkixrvdafv4@jpeg",
							"viewer":
							{
								"muted": false,
								"blockedBy": false
							},
							"labels":
							[]
						},
						"value":
						{
							"text": "*David Attenborough voice* the young sharks gather in the spawning grounds, waiting for the dolls to find them",
							"$type": "app.bsky.feed.post",
							"embed":
							{
								"$type": "app.bsky.embed.images",
								"images":
								[
									{
										"alt": "a large pile of BLÅHAJ ",
										"image":
										{
											"$type": "blob",
											"ref":
											{
												"$link": "bafkreih7blzl33qe3brghoga6fzb6gq4xhglagiqepyfq6wskdrinx24am"
											},
											"mimeType": "image/jpeg",
											"size": 954723
										}
									}
								]
							},
							"langs":
							[
								"en"
							],
							"createdAt": "2023-07-26T20:40:05.511Z"
						},
						"labels":
						[],
						"indexedAt": "2023-07-26T20:40:05.664Z",
						"embeds":
						[
							{
								"$type": "app.bsky.embed.images#view",
								"images":
								[
									{
										"thumb": "https://cdn.bsky.social/imgproxy/K3d3SITTqfkLUvwD4C7Rs1MPu3aGb-ICL7r0W-YKusA/rs:fit:1000:1000:1:0/plain/bafkreih7blzl33qe3brghoga6fzb6gq4xhglagiqepyfq6wskdrinx24am@jpeg",
										"fullsize": "https://cdn.bsky.social/imgproxy/iNqiuE5n5M6mWXkP-1S-eZHk_9kvlu822yv7YX1adPc/rs:fit:2000:2000:1:0/plain/bafkreih7blzl33qe3brghoga6fzb6gq4xhglagiqepyfq6wskdrinx24am@jpeg",
										"alt": "a large pile of BLÅHAJ "
									}
								]
							}
						]
					}
				},
				"media":
				{
					"$type": "app.bsky.embed.images#view",
					"images":
					[
						{
							"thumb": "https://cdn.bsky.social/imgproxy/f_aTws11I8nONbB0qlIQ5eXHEFvaLELJqTN_4T2v_FY/rs:fit:1000:1000:1:0/plain/bafkreif2blhvgss23kj2lqi6b6qkb6jqnz3zze6mvyvh7argmhpealzlw4@jpeg",
							"fullsize": "https://cdn.bsky.social/imgproxy/-msLgPXc7BkLB84gVN6iCUIR7CHOoXdbTkD6YpCeFZY/rs:fit:2000:2000:1:0/plain/bafkreif2blhvgss23kj2lqi6b6qkb6jqnz3zze6mvyvh7argmhpealzlw4@jpeg",
							"alt": ""
						}
					]
				}
			},
			"replyCount": 0,
			"repostCount": 6,
			"likeCount": 50,
			"indexedAt": "2023-07-27T06:24:27.247Z",
			"viewer":
			{},
			"labels":
			[]
		},
		"replies":
		[]
	}
}

Scrxtchy Jul 27, 2023
Author

I should make this a little clearer, this block here is missing on affected post objects

Scrxtchy Jul 27, 2023
Author

EDIT: this is a type problem (explained below)

I've solved the issue, but it's... it's shocking
https://github.com/MarshalX/atproto/blob/main/atproto/xrpc_client/models/app/bsky/feed/defs.py#L25-L33

I moved 'models.AppBskyEmbedRecordWithMedia.View' to the top of the list, and it started filling out the data correctly

View(media=View(images=[ViewImage(alt='',
                                  fullsize='https://cdn.bsky.social/imgproxy/-msLgPXc7BkLB84gVN6iCUIR7CHOoXdbTkD6YpCeFZY/rs:fit:2000:2000:1:0/plain/bafkreif2blhvgss23kj2lqi6b6qkb6jqnz3zze6mvyvh7argmhpealzlw4@jpeg',
                                  thumb='https://cdn.bsky.social/imgproxy/f_aTws11I8nONbB0qlIQ5eXHEFvaLELJqTN_4T2v_FY/rs:fit:1000:1000:1:0/plain/bafkreif2blhvgss23kj2lqi6b6qkb6jqnz3zze6mvyvh7argmhpealzlw4@jpeg',
                                  _type='app.bsky.embed.images#viewImage')],
                _type='app.bsky.embed.images#view'),
     record=View(record=ViewRecord(author=ProfileViewBasic(did='did:plc:z2rokxrttw5254hogmucux2x',
                                                           handle='lookitup.baby',
                                                           avatar='https://cdn.bsky.social/imgproxy/g8exglxR_oanrR1eq-wK_ukYq-SC8_i3dh8td7m0qIQ/rs:fill:1000:1000:1:0/plain/bafkreif7zcepr4rrg3o4gctttycvbklypxvzlpsfd7y4bo2bkixrvdafv4@jpeg',
                                                           displayName='Ian '
                                                                       'Coldwater',
                                                           labels=[],
                                                           viewer=ViewerState(blockedBy=False,
                                                                              blocking=None,
                                                                              followedBy=None,
                                                                              following=None,
                                                                              muted=False,
                                                                              mutedByList=None,
                                                                              _type='app.bsky.actor.defs#viewerState'),
                                                           _type='app.bsky.actor.defs#profileViewBasic'),
                                   cid='bafyreicutqwniezgehk7ie3vxjtkiwyv73oxgqczqpinn6tgf2lq7x32eu',
                                   indexedAt='2023-07-26T20:40:05.664Z',
                                   uri='at://did:plc:z2rokxrttw5254hogmucux2x/app.bsky.feed.post/3k3hbh6k7752z',
                                   value=Main(createdAt='2023-07-26T20:40:05.511Z',
                                              text='*David Attenborough voice* '
                                                   'the young sharks gather in '
                                                   'the spawning grounds, '
                                                   'waiting for the dolls to '
                                                   'find them',
                                              embed=Main(images=[Image(alt='a '
                                                                           'large '
                                                                           'pile '
                                                                           'of '
                                                                           'BLÅHAJ ',
                                                                       image=BlobRef({'$type': 'blob', 'mimeType': 'image/jpeg', 'size': 954723, 'ref': {'$link': 'bafkreih7blzl33qe3brghoga6fzb6gq4xhglagiqepyfq6wskdrinx24am'}}),
                                                                       _type='app.bsky.embed.images#image')],
                                                         _type='app.bsky.embed.images'),
                                              entities=None,
                                              facets=None,
                                              langs=['en'],
                                              reply=None,
                                              _type='app.bsky.feed.post'),
                                   embeds=[View(images=[ViewImage(alt='a large '
                                                                      'pile of '
                                                                      'BLÅHAJ ',
                                                                  fullsize='https://cdn.bsky.social/imgproxy/iNqiuE5n5M6mWXkP-1S-eZHk_9kvlu822yv7YX1adPc/rs:fit:2000:2000:1:0/plain/bafkreih7blzl33qe3brghoga6fzb6gq4xhglagiqepyfq6wskdrinx24am@jpeg',
                                                                  thumb='https://cdn.bsky.social/imgproxy/K3d3SITTqfkLUvwD4C7Rs1MPu3aGb-ICL7r0W-YKusA/rs:fit:1000:1000:1:0/plain/bafkreih7blzl33qe3brghoga6fzb6gq4xhglagiqepyfq6wskdrinx24am@jpeg',
                                                                  _type='app.bsky.embed.images#viewImage')],
                                                _type='app.bsky.embed.images#view')],
                                   labels=[],
                                   _type='app.bsky.embed.record#viewRecord'),
                 _type='app.bsky.embed.record#view'),
     _type='app.bsky.embed.recordWithMedia#view')

Answer selected by Scrxtchy

MarshalX Jul 27, 2023
Maintainer

That's because SDK serializes response as 'app.bsky.embed.record#view' instead of app.bsky.embed.recordWithMedia#view! it's a bug in Python SDK

MarshalX Jul 27, 2023
Maintainer

oh sorry you figure out it already :)

MarshalX Jul 27, 2023
Maintainer

well, that's what we should have at the end

post_uri = 'at://did:plc:hbtuqflamm5j2i7yahtzsnue/app.bsky.feed.post/3k3ic43ucbq2f'
response = client.bsky.feed.get_post_thread({'uri': post_uri, 'depth': 1, 'parentHeight': 0})
assert response.thread.post.embed._type == 'app.bsky.embed.recordWithMedia#view'

and yeah, different order oh union helps

Scrxtchy Jul 27, 2023
Author

I'm not too familiar with typings in all it's glory. Should we track this as an issue here and link to to something upstream if there's something on https://github.com/python/typing ? Or has this actually already been fixed in a newer version (I use 3.10)

Linus2punkt0 · 2023-08-18T11:05:02Z

Linus2punkt0
Aug 18, 2023

Hi! I was just wrestling with this exact problem, is there any update on releasing a fix?

1 reply

MarshalX Aug 18, 2023
Maintainer

Hi @Linus2punkt0. I'm working on it in a separated branch #127. Resolving union types by _type field should solve such problems. Unfortunately, I can't provide any ETA

MarshalX · 2023-08-26T16:23:52Z

MarshalX
Aug 26, 2023
Maintainer

Dev version of AT Protocol SDK powered by Pydantic v2. According to my unit tests, it already fixes all known issues with type resolution in Unions and literals.

code snippet:

post_uri = 'at://did:plc:hbtuqflamm5j2i7yahtzsnue/app.bsky.feed.post/3k3ic43ucbq2f'
response = client.app.bsky.feed.get_post_thread({'uri': post_uri, 'depth': 1, 'parentHeight': 0})
assert response.thread.post.embed.py_type == 'app.bsky.embed.recordWithMedia#view'

now this code doesn't fail and the media is presented correctly

Download: atproto-0.0.25.dev16.tar.gz
TODO list: #127

0 replies

MarshalX · 2023-09-08T00:04:20Z

MarshalX
Sep 8, 2023
Maintainer

Fixed in https://github.com/MarshalX/atproto/releases/tag/v0.0.26

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Getting the View for an Image in a quote post #119

{{title}}

Replies: 4 comments 18 replies

{{title}}

{{title}}

{{title}}

Output

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

Select a reply

Getting the View for an Image in a quote post #119

Scrxtchy Jul 27, 2023

EDIT: this is a type problem (explained below)

Replies: 4 comments · 18 replies

MarshalX Jul 27, 2023 Maintainer

MarshalX Jul 27, 2023 Maintainer

Scrxtchy Jul 27, 2023 Author

Output

Scrxtchy Jul 27, 2023 Author

Scrxtchy Jul 27, 2023 Author

EDIT: this is a type problem (explained below)

MarshalX Jul 27, 2023 Maintainer

MarshalX Jul 27, 2023 Maintainer

MarshalX Jul 27, 2023 Maintainer

Scrxtchy Jul 27, 2023 Author

Linus2punkt0 Aug 18, 2023

MarshalX Aug 18, 2023 Maintainer

MarshalX Aug 26, 2023 Maintainer

MarshalX Sep 8, 2023 Maintainer

Scrxtchy
Jul 27, 2023

Replies: 4 comments 18 replies

MarshalX
Jul 27, 2023
Maintainer

MarshalX Jul 27, 2023
Maintainer

Scrxtchy Jul 27, 2023
Author

Scrxtchy Jul 27, 2023
Author

Scrxtchy Jul 27, 2023
Author

MarshalX Jul 27, 2023
Maintainer

MarshalX Jul 27, 2023
Maintainer

MarshalX Jul 27, 2023
Maintainer

Scrxtchy Jul 27, 2023
Author

Linus2punkt0
Aug 18, 2023

MarshalX Aug 18, 2023
Maintainer

MarshalX
Aug 26, 2023
Maintainer

MarshalX
Sep 8, 2023
Maintainer