Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Receive progress when printing from SD Card #9751

Closed
marcboivin opened this issue Feb 21, 2018 · 8 comments
Closed

[FR] Receive progress when printing from SD Card #9751

marcboivin opened this issue Feb 21, 2018 · 8 comments
Labels
C: Hosts & Protocols T: Feature Request Features requested by users.
Milestone

Comments

@marcboivin
Copy link

It would be of great use to be able to receive print progress when printing from the SD card.

Feature request in OctoPrint to have proper progression when starting a print from the SD card.

A plugin could be made to pool the printer with M27 at a fixed interval, but the much cleaner solution IMHO would be to have a custom G-Code that would enable progress report when printing from the printer's SD card.

My general knowledge of G-Code is quite limited and I couldn't find general design principle on how to correctly implement this feature. I'm opening it here in the hope that the community finds the feature appealing enough to implement.

Feature request from OctoPrint OctoPrint/OctoPrint#2335

Regards,

Marc

@houseofbugs
Copy link
Contributor

#9636

@TheSFReader
Copy link
Contributor

TheSFReader commented Feb 22, 2018

I would like to code the feature, but wonder if it's better as an extension (through an additional / optional parameter) to M27 or as a new M Code (in which case I'll have to find out how they are allocated).

For now, will code as an M27 extension.

I'd add it just like the M155 temp auto report (including the additional capability report).

@TheSFReader
Copy link
Contributor

First implementation pushed to my fork, but since I'm on vacation till sunday, I have no way to test it
https://github.com/TheSFReader/Marlin/tree/Report_SDCardProgress
If anyone is able to check it before Sunday, I'll make a pull request.
The AUTO_REPORT_SD_STATUS option is enabled in the configuration_adv.h, and used with the M27 command :
M27 S5 will (if it's working correctly) auto-report the status every 5 seconds,
M27 S0 should disable the autoreport.

@marcboivin
Copy link
Author

Same here, can't test until Sunday. I asked people from Octoprint if they can test it before that.

Thank you!

@thinkyhead thinkyhead added T: Feature Request Features requested by users. C: Hosts & Protocols labels Feb 23, 2018
@thinkyhead thinkyhead added this to the 2.0.0 milestone Feb 23, 2018
@TheSFReader
Copy link
Contributor

Tested it, corrected it, and sent a pul request #9832

thinkyhead pushed a commit to TheSFReader/Marlin that referenced this issue Feb 26, 2018
thinkyhead pushed a commit that referenced this issue Feb 26, 2018
* SD Status auto-report feature
Feature Request #9751
@thinkyhead
Copy link
Member

Merged into bugfix-2.0.x.

@TheSFReader
Copy link
Contributor

Thanks :-)

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: Hosts & Protocols T: Feature Request Features requested by users.
Projects
None yet
Development

No branches or pull requests

4 participants