Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildTrigger removes GCS tarball source #167

Open
muschellij2 opened this issue Jan 15, 2022 · 3 comments
Open

BuildTrigger removes GCS tarball source #167

muschellij2 opened this issue Jan 15, 2022 · 3 comments

Comments

@muschellij2
Copy link
Contributor

When scheduling, if you're using a tar.gz (e.g. from deploy docker), this clears out that source and causes fails:
https://github.com/MarkEdmondson1234/googleCloudRunner/blob/master/R/buildtriggers.R#L261

@MarkEdmondson1234
Copy link
Owner

This is intentional, as its too confusing having triggers that could be sources (GitHub) have different sources (Cloud Storage). For the new event based buildtriggers the new sourceToBuild field should be used instead.

@muschellij2
Copy link
Contributor Author

I guess what I'm saying is that you cannot simply use a (or it's difficult to find and remember which) .tar.gz to assign to this as this was embedded in the build from before. So removing that source now causes a malformed build.

@MarkEdmondson1234
Copy link
Owner

May I see an example as this isn't a workflow I'm familiar with - perhaps it needs support or some guide rails preventing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants