Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cr_build_wait shows wrong percentage done relative to timeout #147

Open
brancengregory opened this issue Nov 24, 2021 · 2 comments
Open
Labels
bug Something isn't working
Milestone

Comments

@brancengregory
Copy link
Contributor

The percent done relative to timeout is off by a factor of five. So it shows 20% when build time has in fact reached 100% of timeout.

My intuition says that this has to do with the Sys.sleep(5) call and/or the spinner initialization in R/build_admin.R, however I don't know how to go about fixing it efficiently.

Feel free to give me a pointer if you don't have the time to fix. I want to familiarize myself with this codebase because I think it is brilliant and hope to contribute at some point.

@MarkEdmondson1234
Copy link
Owner

Hmm that's annoying! I added the timer last release using cli tools. You are very welcome to take a look, it's in https://github.com/MarkEdmondson1234/googleCloudRunner/blob/master/R/build_admin.R the wait_f does the ticks.

@MarkEdmondson1234 MarkEdmondson1234 added the bug Something isn't working label Nov 24, 2021
@brancengregory
Copy link
Contributor Author

Excellent, thanks, I'll give it a go!

@MarkEdmondson1234 MarkEdmondson1234 added this to the CRAN 0.5.0 milestone Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants