Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnote numbered wrongly when importing footnote with include #2430

Open
yiwen101 opened this issue Feb 19, 2024 · 0 comments
Open

Footnote numbered wrongly when importing footnote with include #2430

yiwen101 opened this issue Feb 19, 2024 · 0 comments
Assignees

Comments

@yiwen101
Copy link
Contributor

yiwen101 commented Feb 19, 2024

Please confirm that you have searched existing issues in the repo

Yes, I have searched the existing issues

Any related issues?

#2203

Tell us about your environment

macOS

MarkBind version

5.2.0

Describe the bug and the steps to reproduce it

Adding this to "topic1.md"

## Footnotes

1 + 1 = 2 ^[Math1]
<div id="examples" class="d-none">

1 + 1 = 2 ^[Math2]
</div>

third test^[last footnote]

Add this to index.md:


footnote1^[first footnote]

<include src = "./topic1.md"></include>

We see:
Screenshot 2024-02-19 at 13 08 55

Expected behavior

1 footnotes that not visible to users are not rendered?
2 footnotes from include are properly indexed and displayed.

Anything else?

I feel it is reasonable to fix this first before fixing #2203, as otherwise we are forced to either:
Add weak test case that do not take care of the id of the footnote
or
Add test case that expect to get footnote with wrong ids

Both ways are not ideal.

@yiwen101 yiwen101 changed the title Footnote numbered wrongly when importing footnote from include Footnote numbered wrongly when importing footnote with include Feb 19, 2024
@yiwen101 yiwen101 self-assigned this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant