Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple External and ExternalManager components #2423

Open
yiwen101 opened this issue Feb 15, 2024 · 0 comments
Open

Decouple External and ExternalManager components #2423

yiwen101 opened this issue Feb 15, 2024 · 0 comments

Comments

@yiwen101
Copy link
Contributor

Please confirm that you have searched existing issues in the repo

Yes, I have searched the existing issues

Any related issues?

This issue is a sub issue of the #2106

What is the area that this feature belongs to?

No response

Is your feature request related to a problem? Please describe.

As mentioned in #1206, External and ExternalManager components are highly coupled as External depends on ExternalManager and ExternalManger depends on External. This makes adding unit test and coming up with mock on them difficult.

Describe the solution you'd like

Refactor the code. This is a good first step towards achieve the goal of boosting test coverage to the core components.

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants