Skip to content
This repository has been archived by the owner on Apr 22, 2021. It is now read-only.

Compact search results in transfer market so you can see the whole page without needing to scroll #245

Open
NewTyp3 opened this issue Oct 28, 2020 · 5 comments

Comments

@NewTyp3
Copy link

NewTyp3 commented Oct 28, 2020

When searching the transfer market I often miss good buys because it takes me time to scroll to the bottom of the page where the latest listings are.

It would be great if there was an option to compact the search results to only show the cards rating, name and price information without the picture and attributes because these aren't needed when buying a card, especially when using the futbin integration.

Here is a screen of how I would like it to look (from FUT20), let me know if any more information would be useful and thank you for all the work you've put in to this app.

image

@yezh-no13
Copy link

yezh-no13 commented Feb 2, 2021

Hi, I agree with you that this feature is very needed according to the fact that @Mardaneus86 introduced 30 item per page as a option. I know how to do it via console of Chrome Developer tools, so it is very simple command when you are standing on the transfer list page:

document.querySelectorAll('.listFUTItem.has-auction-data').forEach(e => e.style = 'height: 40px');

So we can easily introduce element style for these objects I guess . Strange that @Mardaneus86 didn't put this feature in his main code.

@Mardaneus86
Copy link
Owner

Feel free to do a Pull Request. I'm still too occupied with other projects right now.

@yezh-no13
Copy link

yezh-no13 commented Feb 18, 2021

Hi Tim,
I did small separate script in tampermonkey which are doing a job but how to integrate this function into main code I didn't manage that so have a doubt about how to do Pull request for the project:

// ==UserScript==
// @name Height 40 Px
// @namespace http://tampermonkey.net/
// @Version xxx
// @description compressed transfer list
// @author xxx
// @match https://www.ea.com/*/fifa/ultimate-team/web-app/*
// @match https://www.ea.com/fifa/ultimate-team/web-app/*
// @grant GM_addStyle
// ==/UserScript==

function f1() {
let element = document.querySelector('.listFUTItem.has-auction-data')
if (element) {
document.querySelectorAll('.listFUTItem.has-auction-data').forEach(e => {e.style = 'height: 40px'})
}
}
setInterval(f1,1)

@Mardaneus86
Copy link
Owner

You're calling the f1 method 1000 times per second in that script. That's far from efficient, so indeed not good enough to include in this project.

It would also require a settings option so people can opt-in to this if they would want it. So it isn't as simple as it sounds at first glance 😉

@yezh-no13
Copy link

Hi Tim, yes indeed it will be a great feature if this will be as a triggered option in Enhancer menu as you do for instance for 30 items transfer list size or FutBin integration et.c
image
By the way after yesterday EA patch of FUT Webapp we have a problem because functions like 30 items transfer list size or Instantly confirm Buy it Now dialog are not working anymore so if you are planning to fix current build maybe it is a good time to introduce shrinking of transfer list option as we discussed above. Thanks for your reply and I hope that your Enhancer script will be updated soon by you or by somebody who is experienced in that because I don't have enough JS knowledge to fix your build . Cheers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants