Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Not possible to only have buttons (no message) anymore #291

Open
MarcusOtter opened this issue Sep 3, 2022 · 2 comments
Open

馃悰 Not possible to only have buttons (no message) anymore #291

MarcusOtter opened this issue Sep 3, 2022 · 2 comments
Labels
confirmed bug 馃 Something isn't working

Comments

@MarcusOtter
Copy link
Owner

Describe the bug

Realized thatwith the v.3.0.0 update we removed the ability to only have reply buttons, which you could previously achieve by setting the custom message to \n. Now if you set the custom message to only whitespace (or empty), the whole message will be disabled. Easiest fix would be to still send the message if the buttons aren't disabled as well. If both are disabled, don't send a message.

This means disabling the message entirely will be two steps instead of one, but it's more intuitive.

Steps to reproduce the bug

  1. Set the reply message to a new line and leave buttons enabled
  2. Send a message in the auto-thread channel
  3. See no reply message (even when buttons are enabled)

Expected behavior

I expect to see only buttons but no text in the reply message.

@MarcusOtter MarcusOtter added the confirmed bug 馃 Something isn't working label Sep 3, 2022
@MarcusOtter MarcusOtter added the good first issue 馃挌 Good for new contributors label Sep 29, 2022
@MarcusOtter
Copy link
Owner Author

MarcusOtter commented Oct 18, 2022

Oh and we also need a migration script to not change the behavior for the current configs

@MarcusOtter
Copy link
Owner Author

MarcusOtter commented Jan 31, 2023

Actually, it kind of works if you put either ** ** or _ _ as the reply message, as a workaround

image

@MarcusOtter MarcusOtter removed the good first issue 馃挌 Good for new contributors label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed bug 馃 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant