Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listen to map for changes in temporal extent #134

Open
ischneider opened this issue Jan 30, 2015 · 3 comments
Open

listen to map for changes in temporal extent #134

ischneider opened this issue Jan 30, 2015 · 3 comments

Comments

@ischneider
Copy link
Member

And update or warn user as needed.

User actions that trigger:

  • annotations modified done
  • layer added or removed done
  • layer modified

Updates:

  • story boxes
  • timeline/slider done

I had mentioned we might want to warn the user if the temporal extent of the change is outside the current extent indicated by the story boxes but it seems like we could take automatic action:

  • if single story box, simply extend to contain the change done
  • when more than one story box is present
    • if layer extent is before current min extent, extend first story box extent
    • if layer extent is after current max extent, extend last story box extent
    • otherwise, add layer to all intersecting story boxes

If this behavior is not acceptable, we could later add an option to disable (and warn the user)

@bartvde
Copy link
Member

bartvde commented Feb 2, 2015

@ischneider wondering how we will catch layer modified? Since editing would be done in a separate MapLoom instance?

@ischneider
Copy link
Member Author

True layer modified is probably the lowest priority at the moment, especially if we don't integrate with editing in MapLoom.

ischneider added a commit that referenced this issue Feb 10, 2015
- local storage service for persistence
- add/edit/delete working
- playback and timeline
- many tests added
- start/end date in filtering, refs #136
- listen for layer changes and compute time, refs #134
@ischneider
Copy link
Member Author

Partially addressed w/ 0ad37ef - covers cases of annotations modified and layer add/remove with timeline/slider update and single storybox update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants