Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for renaming/replacing SWIG-Mapscript functions #6944

Open
ghschier opened this issue Oct 11, 2023 · 0 comments
Open

Proposal for renaming/replacing SWIG-Mapscript functions #6944

ghschier opened this issue Oct 11, 2023 · 0 comments

Comments

@ghschier
Copy link

The global functions in SWIG regarding HTTP-Headers are confusingly named and do not act as expected.
My propsals would be:

msIO_getAndStripStdoutBufferMimeHeaders()
Does in fact remove all headers (including Status), what is good.
Rename therefore to msIO_getAndStripStdoutBufferHeaders()

msIO_stripStdoutBufferContentHeaders()
Remove or mark as deprecated. Use msIO_getAndStripStdoutBufferHeaders() instead

msIO_stripStdoutBufferContentType()
Does obviously not return the content type, if there is more than 1 header set (see #6762)
Remove or mark as deprecated. Use msIO_getAndStripStdoutBufferHeaders() instead (the function returns the headers in a hashTableObj)

Conclusion
There is only 1 function necessary to handle the HTTP-headers.
The function msIO_getAndStripStdoutBufferHeaders() would replace the 3 existing functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants