Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

range is wrong for only 1 token span #14

Open
thirteenflt opened this issue Jul 19, 2019 · 2 comments · May be fixed by MantisAI/nervaluate#10
Open

range is wrong for only 1 token span #14

thirteenflt opened this issue Jul 19, 2019 · 2 comments · May be fixed by MantisAI/nervaluate#10

Comments

@thirteenflt
Copy link

pred_range = range(pred.start_offset, pred.end_offset)

so if pred.start=1 and pred.end_offset=1, then it will be empty range. But it should be one.
to fix:
pred_range = range(pred.start_offset, pred.end_offset+1)
@davidsbatista
Copy link
Owner

Hi @thirteenflt thanks a lot for making us aware of that, could you maybe open a PR to fix that? I would be really grateful.

@ivyleavedtoadflax
Copy link
Contributor

Good spot!

ivyleavedtoadflax added a commit to MantisAI/nervaluate that referenced this issue Oct 18, 2019
@ivyleavedtoadflax
new: Test evaluation on only one token
f08ba6e 
Follows davidsbatista/NER-Evaluation#14
@ivyleavedtoadflax ivyleavedtoadflax linked a pull request Oct 18, 2019 that will close this issue
Draft
ivyleavedtoadflax added a commit to MantisAI/nervaluate that referenced this issue Dec 7, 2019
@ivyleavedtoadflax
new: Test evaluation on only one token
3f749f5 
Follows davidsbatista/NER-Evaluation#14
ivyleavedtoadflax added a commit to MantisAI/nervaluate that referenced this issue Dec 7, 2019
@ivyleavedtoadflax
new: Test evaluation on only one token
1238c41 
Follows davidsbatista/NER-Evaluation#14
@ivyleavedtoadflax ivyleavedtoadflax mentioned this issue Jun 25, 2021
Open
ivyleavedtoadflax added a commit to MantisAI/nervaluate that referenced this issue Oct 29, 2022
@ivyleavedtoadflax
new: Test evaluation on only one token
a5e0832 
Follows davidsbatista/NER-Evaluation#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Fix single token issue MantisAI/nervaluate
3 participants
@thirteenflt @ivyleavedtoadflax @davidsbatista