Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results display gets messed-up when multiple settings were used on the same folder #217

Open
ibludau opened this issue May 18, 2021 · 0 comments

Comments

@ibludau
Copy link
Contributor

ibludau commented May 18, 2021

Describe the bug
If you run a second analysis on the same folder as a previous analysis then the result files are overwritten. In the GUI you can however still select the yaml of the initial analysis, see the initial parameters, but non-matching results in the tables.

To Reproduce
Steps to reproduce the behaviour:

  1. Run one analysis with FDR=1
  2. Start a second analysis with FDR=0.01 in the same folder (rename the yaml file)
  3. Go to results tab and select the yaml of the first analysis
  4. Select the protein FDR table and sort by FDR >> the maximum FDR is 0.01, if you scroll up to 'run log' it states FDR=1 though

Expected behavior
I think it would be good to either append the name of the yaml file also to all result files as a general suffix for an analysis. This way alternative analysis results can be stored in teh same folder.
Alternatively, if only one set of results should be available per folder, I would suggest to restructure the results panel so that the results.yaml settings are shown and not any settings that were saved by the user at any point. They might not match the shown results.

Version (please complete the following information):

  • OS: Windows 10 Pro
  • Version: 20H2, OS build 19042.804
  • Installation Type: One-Click Installer
@straussmaximilian straussmaximilian added this to In progress in Paper Plan V2 May 19, 2021
@straussmaximilian straussmaximilian moved this from In progress to To do in Paper Plan V2 May 21, 2021
@straussmaximilian straussmaximilian moved this from To do to Backlog in Paper Plan V2 Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant