Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live-Thumbnail generation when project is already open #30

Open
kolibril13 opened this issue Nov 1, 2021 · 3 comments
Open

Live-Thumbnail generation when project is already open #30

kolibril13 opened this issue Nov 1, 2021 · 3 comments
Labels
new feature Feature requested
Milestone

Comments

@kolibril13
Copy link
Member

Currently, all thumbnails are generated before the video editor opens.
I think it would be nice, when one could directly start working without the waiting time, and only dummy-tumbnails are used for the beginning, which are updated on the fly.

@christopher-besch
Copy link
Member

The problem here is that the html buffer player I'm using requires fragmented videos, which have to be created too. That actually takes longer than the thumbnail generation.

There is an alternative, the fallback loader, which doesn't require the videos to be fragmented. But you would still have to copy the videos so the advantage wouldn't be too big.
I think a big part of the problem can already be solved with a better updating system, which only updates the videos that have changed.

And what you're suggesting, asynchronous thumbnail generation and loading, is...not easy, to put it in mild words. For a luxury feature like this I don't really have the resources atm. Sorry

@christopher-besch christopher-besch added this to the Editor milestone Nov 2, 2021
@kolibril13
Copy link
Member Author

Hi Chris, thanks for your message!
I don't have much experience in web-dev, so my naive idea was that this could be implemented in a few minutes.
But as you already do a lot of great work here, I don't think this is something you should waste your time on.
Also, a better updater system might already reduce the loading time a lot, as you say, so I am closing this issue :)

@christopher-besch
Copy link
Member

Thanks for the motivation-boost!
But we can keep the PR open, we might reach a point at which we have the capacity or absolute necessity to implement this.
Or we find a simple way of doing it which I haven't thought of yet.

@christopher-besch christopher-besch added the new feature Feature requested label Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Feature requested
Projects
None yet
Development

No branches or pull requests

2 participants