Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve building bug-fix releases #4

Open
3 tasks
zdavis opened this issue Aug 27, 2020 · 0 comments
Open
3 tasks

Improve building bug-fix releases #4

zdavis opened this issue Aug 27, 2020 · 0 comments

Comments

@zdavis
Copy link
Member

zdavis commented Aug 27, 2020

Currently, if we want to build a patch release, we do this:

./exe/manifold-tools build v5.1.1 --branch=v5.x
./exe/manifold-tools publish v5.1.1 --branch=v5.x

This mostly works, but there are still a few manual cleanup steps that could be automated:

  • When manifold-tools opens the PR against ManifoldScholar/Manifold as part of publishing, the PR is against master instead of against the branch that's being built.
  • When manifold-tools tags the ManifoldScholar/Manifold repo, it checks out master first and tags master. The tag should be on the HEAD of the branch specified by --branch
  • When manifold-tools generates the changelog, it includes all closed PRs to date, not just the ones that appear in the branch that's being built and published.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant