Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation arrow collapses into project title #4

Open
tsmyre opened this issue Aug 25, 2020 · 1 comment · May be fixed by #3
Open

Navigation arrow collapses into project title #4

tsmyre opened this issue Aug 25, 2020 · 1 comment · May be fixed by #3
Assignees
@zdavis

Comments

@tsmyre
Copy link

tsmyre commented Aug 25, 2020

On the Debates instance, when a user navigates to the view where they can manage their reading groups, the menu navigation text overlays the arrow pointing back.

nav
ConnorChristensen referenced this issue in ManifoldScholar/manifold Sep 11, 2020
@ConnorChristensen
[C] Split mixins from structure utility classes
54e12ea 
Issue #2831 is a result of the dhdebates manifold instance including
the duplicate structure utility classes. The plugin required some
mixins, however these mixins came with utility classes that
unintentionally took precedence over custom styles in the plugin and
caused bugs.

Splitting the utility classes from the mixins allows other files to
import mixins without worrying that the structure utilities will
overwrite previously defined values.

This issue will be resolved when the dhdebates plugin imports the
mixin file rather than the whole structure folder contents.
ConnorChristensen referenced this issue Sep 11, 2020
@ConnorChristensen
[B] Remove unintentional utility classes import
b921200 
Resolves manifold issue [#2831](https://github.com/ManifoldScholar/manifold/issues/2831).
ConnorChristensen referenced this issue Sep 11, 2020
@ConnorChristensen
[B] Remove unintentional utility classes import
0f72e67 
Resolves https://github.com/ManifoldScholar/manifold/issues/2831.

Utility classes were accidentally being imported along with mixins
and interfering with the stylesheet.
zdavis referenced this issue in ManifoldScholar/manifold Oct 8, 2020
@ConnorChristensen @zdavis
[C] Split mixins from structure utility classes
b629a8c 
Issue #2831 is a result of the dhdebates manifold instance including
the duplicate structure utility classes. The plugin required some
mixins, however these mixins came with utility classes that
unintentionally took precedence over custom styles in the plugin and
caused bugs.

Splitting the utility classes from the mixins allows other files to
import mixins without worrying that the structure utilities will
overwrite previously defined values.

This issue will be resolved when the dhdebates plugin imports the
mixin file rather than the whole structure folder contents.
@zdavis zdavis transferred this issue from ManifoldScholar/manifold Oct 8, 2020
@zdavis
Copy link
Member

zdavis commented Oct 8, 2020

This is actually not an issue in Manifold per se. It's related to customizations on the DH debates instance. There's an open PR on this issue that will solve it. However, we can't solve this on DH Debates until the Manifold v6 is out, as there's a corresponding upstream fix that won't be included in Manifold until the master branch is released.

@ConnorChristensen ConnorChristensen removed their assignment Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zdavis zdavis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[B] Remove unintentional utility classes import ManifoldScholar/dhdebates-manifold-plugins
3 participants
@zdavis @ConnorChristensen @tsmyre