-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Handle "Not a custom format upgrade" #75
Comments
Could you please
Thx |
|
yes agree on (1). Will build smth for sonarr/radarr; would appreciate if you could then help me with testing / potential debug. thx for the logs, those are helpful Update - just pushed a new version to "dev" - can you please pull the package and test if it does the trick for you? |
Thanks for the quick changes. |
See dev-Readme: |
Sorry missed that readme.
I notice though that it skips entries for private trackers with IGNORE_PRIVATE_TRACKERS=True set. |
Not sure i know what you mean by this, could you pls explain/potentially with screenshots?
|
If you manually try and delete items in Radarr and Sonnarr you get these options: |
If you chose ‚ignore download‘, will it then again start fetching better quality downloads if available (ie queue gets unblocked)? can you chose ‚ignore‘ on one of them and paste the network delete request URL (queue api request)? |
I don't think it will as the download descision maker should block it. The url for the request is
The body is:
|
So did some testing and I noticed that sometimes they get undetected:
I get "Download no longer marked as no format upgrade" but not really sure as to why |
I just added the functionality that for private trackers, the queue items get removed, but not the associated torrent files. In the URL you posted, (and as per your comment) the parameter blocklist=false was set; that in my opinion should be true, else the *arr app will potentially grab that download just once again. Should not be a big deal if that lesser quality torrent is added to blocklist though since you have a better version already anyways?
I turned of the check for x/n times (immediate removal now) |
So finally managed to test again. Firstly I agree on the block thing. Doesn't really matter if we block it because we already have a better version. I did notice however it seems to have stopped reporting on the stuck torrents:
I have several torrents stuck with the 'not a custom format upgrade' but declutarr doesn't seem to see them |
Could you switch to debug mode please, turn off everything but REMOVE_NO_FORMAT_UPGRADE=True and pastebin the logs pls? |
Sure. Had to use WeTransfer though since file was larger than 512KB: |
No wonder it's half a MB: this should be all "False" except for did you do this? :) Looking at your logs, what I observed is that for instance "DD7C74205632DE4E881ADD20F58003D83642AF5D" is on the protectedDownloadIDs list, which means supposedly in qbit it's tagged to keep it and not be removed. can you share a screenshot of that movie from qbit please? Is it really tagged? |
I though the removing meant removed from the queue? They are indeed tagged with '~type_PrivateTracker' sinse I want these to remain in qbit. Also sorry was on my phone so didn't see the last bit |
let's try to break this down. NO_STALLED_REMOVAL_QBIT_TAG -> If a torrent is tagged with this tag, the items in the queue that use this torrent are not removed by any rule IGNORE_PRIVATE_TRACKERS -> If this setting is on, and the torrent in question is a private tracker, the queue item is not removed. Exception: if it's a case of post-download problem (REMOVE_NO_FORMAT_UPGRADE), then the queue item is deleted, but not the torrent. Therefore: if you apply the tag NO_STALLED_REMOVAL_QBIT_TAG to your private trackers, and you already have turned on IGNORE_PRIVATE_TRACKERS, you double-protect them, which is why REMOVE_NO_FORMAT_UPGRADE does not take effect. REMOVE_NO_FORMAT_UPGRADE would in this case (since private tracker) only delete the queue item, but not the torrent. for public trackers, the torrent would be removed too. makes sense? Thus to test this, please
|
So removed the NO_STALLED_REMOVAL_QBIT_TAG and left IGNORE_PRIVATE_TRACKERS enabled but it seems they got removed from qbit: |
Ok. Meaning you‘re happy with the implementation or any open items? |
No I expected the torrents to not be removed since they were from private trackers. If you check the logs it trigger delete from queue with the RemoveFromClient set to true for private trackers. Don't think that's supposed to happen? For example these lines:
|
humm. sorry for that. can you run it again pls and paste the logs? |
No worries. Can always download the torrent again if I get flagged. |
I guess you could simulate it by re-requesting the same torrent that was rejected previously by searching for it manually? Or would that overwrite the better quality version you already have? |
I removed the 'autosearched' tag from upgradinatorr so it will go through each move/series again. Should pull the previously deleted torrent if no new ones popped up. Will keep you posted |
I have a hunch what it could be. you will now see a log entry called "main/privateDowloadIDs: [...]". If that list is empty, it means that for whatever reason your private torrents are not recognized as such.
what i am looking for in 2) is that private trackers should have a key "is_private: true" |
I see this in my logs:
So I guess there's something wrong with the flag? |
|
Image I'm using is: lscr.io/linuxserver/qbittorrent:latest I checked some torrents from each private tracker and they do all have the "is_private": true
|
Ok that‘s interesting.
|
Btw I couldnn't find what you meant with '/torrents/info'. |
I was referring to the network tab (F12 in your browser). |
Oh I know. I just couldn't find any request except the general tab that had the is_private property. |
Which web ui are you using? Mine looks completely different |
Is it possible that the logs you provided are truncated?
just a different skin.
I rewrote a part of the script which detects the private trackers. can you please pull again and test? |
Ah cool didn't know you had skins. Managed to update in the meantime: |
I think I've found out what's going on. the /info API of qBit does not return the isPrivate flag, only the /properties returns it.. Inconvenient, because the /properties needs to be queried for each torrent separately. Created a PR on qBit, maybe the flag can be added to the response of the /info API, so that we don't have to fetch it individually for each torrent from the /properties API: Let's see what they say. If they don't approve the PR in the next days, I'll update the code on my end to fetch it via the /properties api |
Ok sounds good. Thanks btw for the quick reponse/coding! |
I've changed the API call on my side. Can you pls check out dev if it works for you now? |
Sorry for the delay. Was busy with work. |
Lines 4136/4137:
Further up you see the zillion calls to qbittorrent; that is because I needed to fire a separate call to the "properties" api for each hash individually since the "info" api of qbit doesn't return the isPrivate flag (PR still open).
Now that the private ones get correctly identified, does what you wanted to get work (for private ones that failed import since no format upgrade that they don't get deleted from qbit, but removed from *arr app)? See entries like on line 1386: |
Did some double checks and it seems they are correctly identified now. Btw are they also blocklisted if they get removed? Just curious because as you said otherwise they would be pulled again |
They do get blocklisted, although I think it would not matter.
now we kill the 720p and blocklist it. so the arr apps would not fetch this specific torrent again. just my 2 cents, not sure it's correct. as long as the result is what you wanted it to be, I'm happy. |
Yea that's probably why. Will save me a lot of time going forwards. Thanks man :D |
My setup is fully automated using the trash guides but I've noticed quite a lot of downloads get stuck in queue with message. (Not a Custom Format upgrade for existing movie file(s))
I was wondering if could get something to remove these items as well?
The text was updated successfully, but these errors were encountered: