Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ansible tower and embedded workflows lists #9181

Merged
merged 1 commit into from
May 24, 2024

Conversation

GilbertCherrie
Copy link
Member

@GilbertCherrie GilbertCherrie commented May 8, 2024

Fixes: #8987
Also needs this pr: ManageIQ/manageiq#23032 to fix the title

Before:
On the Automation / Automation / Templates screen the list is showing Workflow instances in the list.
Screenshot 2024-05-08 at 2 00 58 PM

On the Automation / Embedded Automate / Customization / Create or Edit Service Dialog screen when using a dynamic drop down with embedded workflows it shows ansible repositories in the list.
Screenshot 2024-05-08 at 2 04 02 PM

After:
Workflow instances no longer show up in the Ansible Tower Templates list.
Screenshot 2024-05-08 at 2 04 49 PM

The embedded workflows list on the service dialog for dynamic drop downs now only shows embedded workflow repositories.
Screenshot 2024-05-08 at 2 06 09 PM

@miq-bot
Copy link
Member

miq-bot commented May 8, 2024

Checked commit GilbertCherrie@c3dbd5f with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
3 files checked, 0 offenses detected
Everything looks fine. 🍰

@jeffbonson jeffbonson merged commit 960ba3a into ManageIQ:master May 24, 2024
15 checks passed
@GilbertCherrie GilbertCherrie deleted the fix_ansible_tower_table branch May 24, 2024 12:55
@Fryguy
Copy link
Member

Fryguy commented May 24, 2024

Backported to radjabov in commit 1eee103.

commit 1eee103761d80ba2c20060a3942a8f6339759097
Author: Jeffrey bonson <jeffbonson@gmail.com>
Date:   Fri May 24 15:58:49 2024 +0530

    Merge pull request #9181 from GilbertCherrie/fix_ansible_tower_table
    
    Fix ansible tower and embedded workflows lists
    
    (cherry picked from commit 960ba3a33ae891897a0444af7108c0a3e73b9773)

Fryguy pushed a commit that referenced this pull request May 24, 2024
Fix ansible tower and embedded workflows lists

(cherry picked from commit 960ba3a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow Instances show up in Ansible Tower / Templates
6 participants