Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow Instances show up in Ansible Tower / Templates #8987

Closed
agrare opened this issue Dec 6, 2023 · 5 comments · Fixed by #9181
Closed

Workflow Instances show up in Ansible Tower / Templates #8987

agrare opened this issue Dec 6, 2023 · 5 comments · Fixed by #9181
Assignees
Labels

Comments

@agrare
Copy link
Member

agrare commented Dec 6, 2023

image

@agrare agrare added the bug label Dec 6, 2023
@Fryguy
Copy link
Member

Fryguy commented Dec 6, 2023

@DavidResende0 Can you take a look at this one?

@miq-bot
Copy link
Member

miq-bot commented Mar 11, 2024

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

@miq-bot miq-bot added the stale label Mar 11, 2024
@Fryguy Fryguy removed the stale label May 7, 2024
@Fryguy
Copy link
Member

Fryguy commented May 7, 2024

@GilbertCherrie Please take a look at this one. Note that I'm also seeing this when I choose a workflow in the dialog field edit screen.
ManageIQ__Automation

@Fryguy
Copy link
Member

Fryguy commented May 7, 2024

I'm also seeing other problems with the dialog edit screen.

  • Sorting on the screen is random. I'm thinking we should sort by repository, then by workflow name
  • There's an N+1 under the covers:
[----] D, [2024-05-07T11:30:30.098541#69509:f078] DEBUG -- :    (0.2ms)  SELECT COUNT(*) FROM "configuration_scripts" WHERE "configuration_scripts"."type" IN ($1, $2, $3, $4, $5, $6, $7, $8, $9)  [["type", "ConfigurationScriptPayload"], ["type", "ManageIQ::Providers::AutomationManager::ConfigurationScriptPayload"], ["type", "ManageIQ::Providers::EmbeddedAutomationManager::ConfigurationScriptPayload"], ["type", "ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Playbook"], ["type", "ManageIQ::Providers::EmbeddedTerraform::AutomationManager::Template"], ["type", "ManageIQ::Providers::Workflows::AutomationManager::Workflow"], ["type", "ManageIQ::Providers::ExternalAutomationManager::ConfigurationScriptPayload"], ["type", "ManageIQ::Providers::AnsibleTower::AutomationManager::Playbook"], ["type", "ManageIQ::Providers::Awx::AutomationManager::Playbook"]]
[----] D, [2024-05-07T11:30:30.099473#69509:f078] DEBUG -- :   ConfigurationScriptPayload Load (0.5ms)  SELECT "configuration_scripts".* FROM "configuration_scripts" WHERE "configuration_scripts"."type" IN ($1, $2, $3, $4, $5, $6, $7, $8, $9) LIMIT $10 OFFSET $11  [["type", "ConfigurationScriptPayload"], ["type", "ManageIQ::Providers::AutomationManager::ConfigurationScriptPayload"], ["type", "ManageIQ::Providers::EmbeddedAutomationManager::ConfigurationScriptPayload"], ["type", "ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Playbook"], ["type", "ManageIQ::Providers::EmbeddedTerraform::AutomationManager::Template"], ["type", "ManageIQ::Providers::Workflows::AutomationManager::Workflow"], ["type", "ManageIQ::Providers::ExternalAutomationManager::ConfigurationScriptPayload"], ["type", "ManageIQ::Providers::AnsibleTower::AutomationManager::Playbook"], ["type", "ManageIQ::Providers::Awx::AutomationManager::Playbook"], ["LIMIT", 1000], ["OFFSET", 0]]
[----] D, [2024-05-07T11:30:30.108334#69509:f078] DEBUG -- :   ConfigurationScriptPayload Inst Including Associations (8.3ms - 71rows)
[----] D, [2024-05-07T11:30:30.122590#69509:f078] DEBUG -- :   ConfigurationScriptSource Load (1.4ms)  SELECT "configuration_script_sources".* FROM "configuration_script_sources" WHERE "configuration_script_sources"."id" = $1 LIMIT $2  [["id", 1], ["LIMIT", 1]]
[----] D, [2024-05-07T11:30:30.161281#69509:f078] DEBUG -- :   ConfigurationScriptSource Inst Including Associations (38.5ms - 1rows)
[----] D, [2024-05-07T11:30:30.162582#69509:f078] DEBUG -- :   ConfigurationScriptSource Load (0.6ms)  SELECT "configuration_script_sources".* FROM "configuration_script_sources" WHERE (configuration_script_sources.id IN (1))
[----] D, [2024-05-07T11:30:30.162781#69509:f078] DEBUG -- :   ConfigurationScriptSource Inst Including Associations (0.1ms - 1rows)
[----] D, [2024-05-07T11:30:30.164012#69509:f078] DEBUG -- :   ConfigurationScriptSource Load (0.2ms)  SELECT "configuration_script_sources".* FROM "configuration_script_sources" WHERE "configuration_script_sources"."id" = $1 LIMIT $2  [["id", 3], ["LIMIT", 1]]
[----] D, [2024-05-07T11:30:30.170893#69509:f078] DEBUG -- :   ConfigurationScriptSource Inst Including Associations (6.7ms - 1rows)
[----] D, [2024-05-07T11:30:30.171798#69509:f078] DEBUG -- :   ConfigurationScriptSource Load (0.5ms)  SELECT "configuration_script_sources".* FROM "configuration_script_sources" WHERE (configuration_script_sources.id IN (3))
[----] D, [2024-05-07T11:30:30.172064#69509:f078] DEBUG -- :   ConfigurationScriptSource Inst Including Associations (0.1ms - 1rows)
[----] D, [2024-05-07T11:30:30.172898#69509:f078] DEBUG -- :   CACHE ConfigurationScriptSource Load (0.0ms)  SELECT "configuration_script_sources".* FROM "configuration_script_sources" WHERE "configuration_script_sources"."id" = $1 LIMIT $2  [["id", 3], ["LIMIT", 1]]
[----] D, [2024-05-07T11:30:30.173076#69509:f078] DEBUG -- :   ConfigurationScriptSource Inst Including Associations (0.1ms - 1rows)
[----] D, [2024-05-07T11:30:30.173319#69509:f078] DEBUG -- :   CACHE ConfigurationScriptSource Load (0.0ms)  SELECT "configuration_script_sources".* FROM "configuration_script_sources" WHERE (configuration_script_sources.id IN (3))
[----] D, [2024-05-07T11:30:30.173385#69509:f078] DEBUG -- :   ConfigurationScriptSource Inst Including Associations (0.0ms - 1rows)
[----] D, [2024-05-07T11:30:30.173985#69509:f078] DEBUG -- :   CACHE ConfigurationScriptSource Load (0.0ms)  SELECT "configuration_script_sources".* FROM "configuration_script_sources" WHERE "configuration_script_sources"."id" = $1 LIMIT $2  [["id", 1], ["LIMIT", 1]]
[----] D, [2024-05-07T11:30:30.174060#69509:f078] DEBUG -- :   ConfigurationScriptSource Inst Including Associations (0.0ms - 1rows)
[----] D, [2024-05-07T11:30:30.174227#69509:f078] DEBUG -- :   CACHE ConfigurationScriptSource Load (0.0ms)  SELECT "configuration_script_sources".* FROM "configuration_script_sources" WHERE (configuration_script_sources.id IN (1))
[----] D, [2024-05-07T11:30:30.174286#69509:f078] DEBUG -- :   ConfigurationScriptSource Inst Including Associations (0.0ms - 1rows)
[----] D, [2024-05-07T11:30:30.174822#69509:f078] DEBUG -- :   CACHE ConfigurationScriptSource Load (0.0ms)  SELECT "configuration_script_sources".* FROM "configuration_script_sources" WHERE "configuration_script_sources"."id" = $1 LIMIT $2  [["id", 3], ["LIMIT", 1]]
[----] D, [2024-05-07T11:30:30.174889#69509:f078] DEBUG -- :   ConfigurationScriptSource Inst Including Associations (0.0ms - 1rows)
[----] D, [2024-05-07T11:30:30.175046#69509:f078] DEBUG -- :   CACHE ConfigurationScriptSource Load (0.0ms)  SELECT "configuration_script_sources".* FROM "configuration_script_sources" WHERE (configuration_script_sources.id IN (3))
... (for a while)

@jeffibm
Copy link
Member

jeffibm commented May 8, 2024

Here is what I see in the local environment -

Screen.Recording.2024-05-08.at.11.18.21.AM.mov

Earlier we used to have the error messages on the Save buttons title (Hover on the Save button).

Recently we made a few changes in ManageIQ/ui-components#486 to change the way we display the error notifications.

API used to fetch the data -
/api/configuration_script_payloads/?expand=resources&attributes=configuration_script_source.name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants