Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentications settings are inserted at every pod start causing multiple configuration values for the same key and resource #781

Open
evertmulder opened this issue Dec 14, 2021 · 6 comments
Assignees

Comments

@evertmulder
Copy link

evertmulder commented Dec 14, 2021

  1. Describe the issue
    Every restart of the orchestrator pod adds a new set of authentication settings. I expect it to add if the setting does not exist, update if the setting exists for the resource (resource_type & resource_id combination)

  2. Describe steps to reproduce
    restart the orchestration pod.

  • ManageIQ version: Kasparov, issue still present in main branch

The line

MiqRegion.my_region.add_settings_for_resource(settings)

This line adds a new set of authentication settings for the region, not updating current settings.

This causes multiple values for the same key and resource.

select count(*) from settings_changes where key='/authentication/provider_type' and resource_type='MiqRegion' and resource_id=9;
 count 
-------
    43
(1 row)

The count should be always 1 (or 0) for a specific key and resource.

@miq-bot add-label bug

@miq-bot miq-bot added the bug label Dec 14, 2021
@Fryguy
Copy link
Member

Fryguy commented Dec 14, 2021

Thanks for the report @evertmulder ! cc @bdunne .

@Fryguy Fryguy self-assigned this Dec 14, 2021
@evertmulder evertmulder changed the title Authentications are inserted at every pod start causing multiple configuration values for the same key and resource Authentications settings are inserted at every pod start causing multiple configuration values for the same key and resource Dec 15, 2021
@miq-bot miq-bot added the stale label Feb 27, 2023
@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2023

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot
Copy link
Member

miq-bot commented May 29, 2023

This issue has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this issue if this issue is still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot miq-bot closed this as completed May 29, 2023
@kbrock kbrock removed the stale label Jun 12, 2023
@kbrock
Copy link
Member

kbrock commented Jun 12, 2023

I just ran into this.

@Fryguy Fryguy reopened this Jun 12, 2023
@Fryguy Fryguy removed their assignment Jun 12, 2023
@Fryguy
Copy link
Member

Fryguy commented Jun 12, 2023

@kbrock Can you look into it if you can reproduce? I haven't had cycles for it

@kbrock
Copy link
Member

kbrock commented Jun 12, 2023

@Fryguy Hulk had this in it.
I tried from rails console and from the specs and was not able. Will try again.

@kbrock kbrock self-assigned this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants