Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL task name issue #3

Open
biplobice opened this issue May 22, 2018 · 1 comment
Open

MySQL task name issue #3

biplobice opened this issue May 22, 2018 · 1 comment

Comments

@biplobice
Copy link
Contributor

https://github.com/concrete5cojp/ansible-c5-ma/blob/master/prod-ansible-role/roles/mysql_server/tasks/main.yml#L17

This task name should be changed. With if condition either Restart mysqld (CentOS6) or Restart mysqld (CentOS7)

IMHO, it's better to name it as only Restart mysqld then apply the if inside the task. i.e.-

Name: Restart mysqld
if(centos_version = 6) {
    // Run command as 6
} else {
   // Run command as 7
}

@katzueno
Copy link
Contributor

Thx.
Would you send me a PR when you have a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants