Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HD 143006 Imaging Tutorial Part 3 #63

Open
iancze opened this issue Jun 1, 2021 · 6 comments
Open

HD 143006 Imaging Tutorial Part 3 #63

iancze opened this issue Jun 1, 2021 · 6 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@iancze
Copy link
Collaborator

iancze commented Jun 1, 2021

An overview of the HD 143006 imaging series is provided in #25

Part III is meant to be the "production-ready" version of a MPoL imaging script. The idea is to use computational resources to do hyperparameter sweeps. One example is using Ray Tune, though we might also want to suggest alternatives.

  • Explore "production-ready" scripting layouts (no Jupyter notebooks). Some useful code and directory structures here.
  • We have a starting point in the examples/HD143006 subdirectory. These need to be improved to be more generalizable (no hardcoded paths) similar to the examples in the Pytorch directory. We also need to document how to visualize loss, etc. with tensorboard.
    * Explore thorough hyperparameter testing with Ray Tune.
  • Develop new priors if necessary to achieve a good image

This "tutorial" document might not actually be a *.py file -> Jupytext -> ipynb like the other tutorials. Rather, it might just be a regular *.rst file with text describing how one might go about running the each of the steps. If necessary, we can include a final notebook that uses the optimal parameters to visualize the best-fit image.

@iancze iancze added the documentation Improvements or additions to documentation label Jun 1, 2021
@iancze iancze added this to To do in DSHARP HD 143006 Tutorial via automation Jun 1, 2021
@iancze iancze self-assigned this Jun 1, 2021
@iancze iancze mentioned this issue Jun 2, 2021
@iancze iancze moved this from To do to In progress in DSHARP HD 143006 Tutorial Jun 13, 2021
@RCF42 RCF42 modified the milestone: Spectral Dimension Sep 16, 2021
@jeffjennings
Copy link
Contributor

Suggest adding a step demonstrating 'pre-training' to a dirty image (#206) to this tutorial.

@jeffjennings
Copy link
Contributor

Suggest adding mention of use of a learning rate scheduler (#207) to this tutorial.

@jeffjennings
Copy link
Contributor

jeffjennings commented Nov 30, 2023

Suggest adding the training diagnostic figure generated by #208 to this tutorial.

@iancze
Copy link
Collaborator Author

iancze commented Nov 30, 2023

All sounds good. I suggest we descope Ray from the original issue, as well.
Depending on how the training and crossval stuff ends up, I think we should also revise Tutorial 2, or possibly combine 2&3.

@jeffjennings jeffjennings self-assigned this Nov 30, 2023
@jeffjennings
Copy link
Contributor

Suggest adding the image comparison figure generated by #211 to this tutorial.

@jeffjennings
Copy link
Contributor

All sounds good. I suggest we descope Ray from the original issue, as well. Depending on how the training and crossval stuff ends up, I think we should also revise Tutorial 2, or possibly combine 2&3.

Cool, I strikethrough'ed the Ray bullet. And that sounds great. Seems like a good time to come to this would be once the total flux prior is implemented and a couple more diagnostic figures I want to add are done. #142 would also be worth addressing (adding figures made by vis_histogram_fig and split_diagnostics_fig figures to the tutorials) when we address this.

There's a separate issue for this #134, but I'd also like to have a tutorial on the fit 'pipeline' (running a full optimization workflow with python -m mpol.pipeline) when that's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Development

No branches or pull requests

4 participants