Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify matplotlib plotting #253

Open
iancze opened this issue Jan 8, 2024 · 0 comments
Open

Simplify matplotlib plotting #253

iancze opened this issue Jan 8, 2024 · 0 comments

Comments

@iancze
Copy link
Collaborator

iancze commented Jan 8, 2024

I discovered by accident that a recent version of PyTorch implemented the ndim attribute, making it possible to use matplotlib routines to plot PyTorch tensors directly. I would suspect this works only if tensors are on the CPU, but I haven't checked.

We should figure out which torch version implemented this, bump to that as a minimum, and then simplify our plotting routines. I suspect we could remove many torch2npy calls and just plot tensors directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant