Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Location.openingHours.isOpen fails for opening hours past midnight #838

Closed
Sir-Photch opened this issue May 14, 2024 · 1 comment
Closed

Location.openingHours.isOpen fails for opening hours past midnight #838

Sir-Photch opened this issue May 14, 2024 · 1 comment

Comments

@Sir-Photch
Copy link
Sponsor Contributor

Sir-Photch commented May 14, 2024 •
edited

On a monday at roughly 10PM

Shown:

markup_1000020840.png

Actually:

markup_1000020841.png

Maybe it would make sense to write some unit tests for OSM parsing?
MM2-0 added a commit that referenced this issue May 17, 2024
@MM2-0
Add unit tests for OpeningSchedule.isOpen
2319e47 
Issue #838
@MM2-0
Copy link
Owner

MM2-0 commented May 17, 2024 •
edited

I'd say OSM parsing is fine, but isOpen isn't working correctly.

@MM2-0 MM2-0 closed this as completed in f68f017 May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MM2-0 @Sir-Photch